Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX alterationType with entityDelete not working if condition.attrs is empty #4326

Merged
merged 7 commits into from
May 12, 2023

Conversation

fgalan
Copy link
Member

@fgalan fgalan commented May 10, 2023

Issue #4325

doc/manuals/orion-api.md Outdated Show resolved Hide resolved
@fgalan
Copy link
Member Author

fgalan commented May 10, 2023

@fisuda this PR does a slight modification in documentation. It would be great if you could do a side PR to upgrade Japanese translation (maybe using bug/4325_entityDelete_ignores_attrs branch as base, so it integrates into this PR). Thanks!

@fisuda
Copy link
Contributor

fisuda commented May 11, 2023

I sent the PR #4328. Thanks.

(JP) Update documentation about entityDelete
@fgalan fgalan requested a review from AlvaroVega May 12, 2023 07:40
Copy link
Member

@AlvaroVega AlvaroVega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlvaroVega AlvaroVega merged commit 9f6805b into master May 12, 2023
@fgalan fgalan deleted the bug/4325_entityDelete_ignores_attrs branch May 12, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants