Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transaction_end must be moved to a higher level #478

Closed
kzangeli opened this issue Jul 29, 2014 · 3 comments
Closed

transaction_end must be moved to a higher level #478

kzangeli opened this issue Jul 29, 2014 · 3 comments
Assignees
@kzangeli
Labels
bug P9
Milestone
Release 0.14.2-ne...

Comments

@kzangeli
Copy link
Member

Description

TRANSACTION_END right now is done in a too low level function.
In case of an update with notifications, one TRANSACTION_END will be issued per notification.
The use of the TRANSACTION_END macro must be moved up. Possibly also TRANSACTION_START.
@kzangeli kzangeli added the P7 label Jul 29, 2014
@kzangeli kzangeli added this to the Release 0.14.1 milestone Jul 29, 2014
@kzangeli kzangeli self-assigned this Jul 29, 2014
@fgalan
Copy link
Member

fgalan commented Jul 29, 2014

TRANSACTION_END right now is done in a too low level function.

Being precise... "TRANSACTION_END related with notifications right now is done in a too low level function". I think that the TRANSACTION_END related with ending the NGSI transaction is well placed right now.

@kzangeli kzangeli mentioned this issue Jul 29, 2014
Merged
@fgalan
Copy link
Member

fgalan commented Jul 29, 2014

There is an error related with message about notifications after transaction end messages. Have a look to the last comment in PR #480

@fgalan fgalan added P9 and removed P7 labels Jul 31, 2014
@kzangeli kzangeli mentioned this issue Aug 5, 2014
Merged
@fgalan
Copy link
Member

fgalan commented Aug 8, 2014

Fixed in PR #498 (and #508)

@fgalan fgalan removed the must label Sep 15, 2014
@fgalan fgalan closed this as completed Sep 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kzangeli kzangeli

Labels
bug P9
Projects
None yet
Milestone
Release 0.14.2-never-released
Development

No branches or pull requests
2 participants
@fgalan @kzangeli