Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update forwarding was not working when entity type is not included in the request #4460

Closed
fgalan opened this issue Dec 21, 2023 · 1 comment
Labels
Milestone

Comments

@fgalan
Copy link
Member

fgalan commented Dec 21, 2023

Considering the following update forwarding request case:

WARN@2023-12-21T09:53:59.504Z AlarmManager.cpp[612]: Releasing alarm BadInput 127.0.0.1
ERROR@2023-12-21T09:53:59.510Z postUpdateContext.cpp[644]: Runtime Error (attribute 'profile_config' not found)
INFO@2023-12-21T09:53:59.510Z logTracing.cpp[231]: Starting forwarding for PUT /v2/entities/device:wt:13@yy/attrs/profile_config
INFO@2023-12-21T09:53:59.511Z logTracing.cpp[296]: Request forwarded (regId: xx): POST http://localhost:1027/v2/op/update, request payload (155 bytes): {"entities":[{"id":"device:wt:13@yy","type":"Device","profile_config":{"type":"command","value":"foobar","metadata":{}}}],"actionType":"update"}, response payload (0 bytes): , response code: 204
INFO@2023-12-21T09:53:59.511Z logTracing.cpp[206]: Request received: PUT /v2/entities/device:wt:13@yy/attrs/profile_config, request payload (170 bytes): {"type":"command","value":"foobar"}, response code: 204

The Runtime Error should not be logged.

@fgalan fgalan added the bug label Dec 21, 2023
@fgalan fgalan added this to the 3.11.0 milestone Dec 21, 2023
@fgalan
Copy link
Member Author

fgalan commented Dec 22, 2023

After investigation (see PR #4463) this goes beyond a overlogging error. Issue title changed accordingly.

@fgalan fgalan changed the title Overloging Runtime Error on forwarding update request case Update forwarding was not working when entity type is not included in the request Dec 22, 2023
@fgalan fgalan closed this as completed Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant