Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dateExpires shouldn't be include in GET /v2/types #4451

Closed
fgalan opened this issue Dec 12, 2023 · 3 comments
Closed

dateExpires shouldn't be include in GET /v2/types #4451

fgalan opened this issue Dec 12, 2023 · 3 comments
Labels
Milestone

Comments

@fgalan
Copy link
Member

fgalan commented Dec 12, 2023

According to documentation (https://github.com/telefonicaid/fiware-orion/blob/master/doc/manuals/orion-api.md#the-dateexpires-attribute) dateExpires should be treated as a built-in attribute that must not be included expect if expectedly asked for.

It seems that is working that way in GET /v2/entities... operations, but in GET /v2/types is included. The solution is applying the same treatment that for other built-ins that are working correctly (e.g. dateModified).

Request used for testing:

https://localhost/cb/v2/types?limit=1000&offset=0&options=noAttrDetail
@fgalan fgalan added the bug label Dec 12, 2023
@fgalan fgalan added this to the 3.11.0 milestone Dec 12, 2023
@fgalan fgalan changed the title dateExpires shouldn't be include in GET /v2/types? dateExpires shouldn't be include in GET /v2/types Dec 12, 2023
@PradyumnAgrawal05
Copy link

Hi @fgalan, I'm interested in working on this issue!

The documentation states that dateExpires should be treated as a built-in attribute and should not be included by default, except if explicitly asked for.

In the GET /v2/entities operations, this behavior seems to be working correctly.

However, in the GET /v2/types operation, dateExpires is included in the response, and this behavior is inconsistent with the documentation.

Please confirm my understanding.

@fgalan
Copy link
Member Author

fgalan commented Dec 19, 2023

First of all, thanks for your willingness to contribute to Orion Context Broker!

This issue is somehow urgent (we want to fix it before closing next release, that will be done at the beginning of new year) so I was thinking on taking care of it myself.

Except if you tell me that you have the solution to this almost ready :) I'd suggest you to pick another issue, please.

@fgalan
Copy link
Member Author

fgalan commented Jan 11, 2024

PR #4467

@fgalan fgalan closed this as completed Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants