Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include notification payloads in INFO level #4449

Closed
1 of 3 tasks
fgalan opened this issue Nov 30, 2023 · 1 comment
Closed
1 of 3 tasks

Include notification payloads in INFO level #4449

fgalan opened this issue Nov 30, 2023 · 1 comment
Labels
Milestone

Comments

@fgalan
Copy link
Member

fgalan commented Nov 30, 2023

Is your feature request related to a problem / use case? Please describe.

According to https://github.com/telefonicaid/fiware-orion/blob/master/doc/manuals/admin/logs.md#info-level-in-detail, notifications produce a trace like this:

HTTP:

time=2020-10-26T10:32:22.145Z | lvl=INFO | corr=87f708a8-1776-11eb-b327-000c29df7908; cbnotif=1 | trans=1603707992-318-00000000003 | from=0.0.0.0 | srv=s1| subsrv=/A | comp=Orion | op=logTracing.cpp[63]:logInfoHttpNotification | msg=Notif delivered (subId: 5f914177334436ea590f6edb): POST localhost:1028/accumulate, response code: 200

MQTT:

time=2020-10-26T10:32:22.145Z | lvl=INFO | corr=87f708a8-1776-11eb-b327-000c29df7908; cbnotif=1 | trans=1603707992-318-00000000003 | from=0.0.0.0 | srv=s1| subsrv=/A | comp=Orion | op=logTracing.cpp[63]:logInfoMqttNotification | msg=MQTT Notif delivered (subId: 60ffea6c1bca454f9a64c96c): broker: localhost:1883, topic: sub2

Surprisingly, the payload of the notification is not include in the trace, as it is done with regular requests.

Describe the solution you'd like

Probably when we re-designed the INFO log level in Orion 2.5.0 we though that it was not relevant information, as the same information is included in the triggered update that can be get using corr=. However, newer versions of Orion has implemented features that allow to deeply transform the notification payload (custom notifications improvements) so now it seems a good idea to include payload also in that cases.

Describe alternatives you've considered

None

Describe why you need this feature

  • To improve or simplify an scenario.

Do you have the intention to implement the solution

  • Yes, I have the knowledge to implement this new feature.
  • Yes, but I will need help.
  • No, I do not have the skills.
@fgalan fgalan added the backlog label Nov 30, 2023
@fgalan fgalan added this to the 3.11.0 milestone Dec 20, 2023
@fgalan
Copy link
Member Author

fgalan commented Dec 20, 2023

PR #4456

@fgalan fgalan closed this as completed Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant