Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in v2/registrations/{registrationId} if the registrationId is unknown returns in http code a 200 instead of a 404 #4235

Closed
OASTEST2022 opened this issue Nov 22, 2022 · 3 comments
Labels
Milestone

Comments

@OASTEST2022
Copy link

in v2/registrations/{registrationId} if the registrationId is unknown returns in http code a 200 and empty value instead of a 404 and error message.

registrationId request

GET http://localhost:1026/v2/registrations/testtesttesttesttesttest
  -H 'accept: application/json'

Response body

http code :200

{
   "error" : "NotFound",
   "description" : "the requested registration has not been found.Check id"
}

Response headers

connection : Keep-alive
content-length : 92
content-type : application/json
date : Thu,27 Oct 2022 08:59:46 GMT
fiware-correlator :
server : nginx
@fgalan
Copy link
Member

fgalan commented Dec 16, 2022

Fixed by PR #4250

@fgalan fgalan added this to the 3.8.0 milestone Dec 16, 2022
@fgalan
Copy link
Member

fgalan commented Dec 16, 2022

@OASTEST2022 thanks for the report! Surprisingly, this passed unnoticed until now :)

PR #4248 should fix the issue. It has been merged to master, so you could test telefonicaiot/fiware-orion:latest

Could you test and tell us if it is working now for you, please? Thanks!

@fgalan
Copy link
Member

fgalan commented Jan 12, 2023

Orion 3.8.0 is has been released today, so we close this issue.

Of course, it could be re-opened if needed.

@fgalan fgalan closed this as completed Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants