Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include offending id in "Invalid characters in entity id" logs #4121

Closed
fgalan opened this issue May 12, 2022 · 1 comment
Closed

Include offending id in "Invalid characters in entity id" logs #4121

fgalan opened this issue May 12, 2022 · 1 comment
Labels
backlog
Milestone
3.7.0

Comments

@fgalan
Copy link
Member

fgalan commented May 12, 2022

Currently we have traces likes this one:

msg=Raising alarm BadInput 10.x.x.x: Invalid characters in entity id

It would be great to include information about the offending id, eg:

msg=Raising alarm BadInput 10.x.x.x: Invalid characters in entity id: lamp(001)

Only for logs. In the responses we will not modify current behaviour. It's not a good idea to pass-through request strings to responses in order to avoid injection attacks.

If similar cases are spotted while working on this issue, improve them also.
@fgalan fgalan added the backlog label May 12, 2022
@fgalan fgalan added this to the 3.7.0 milestone May 12, 2022
@fgalan fgalan mentioned this issue May 19, 2022
Merged
@fgalan
Copy link
Member Author

fgalan commented May 19, 2022

PR #4130

@fgalan fgalan closed this as completed May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog
Projects
None yet
Milestone
3.7.0
Development

No branches or pull requests
1 participant
@fgalan