Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unhardwire HTTP headers strings #3035

Closed
fgalan opened this issue Nov 10, 2017 · 5 comments
Closed

Unhardwire HTTP headers strings #3035

fgalan opened this issue Nov 10, 2017 · 5 comments
Assignees
@McMutton
Labels
good first issue should techdebt
Milestone
1.14.0

Comments

@fgalan
Copy link
Member

fgalan commented Nov 10, 2017

Raised in #3032 (comment)

Headers names are now being defined at HttpHeaders.h. Thus, we have to tasks to do:

  1. Look for ocurrences of these headers in order to replace the literal string by the define constant
  2. Look for other headers literals, to enrich the current set in HttpHeaders.h

The final goal is not having any literal string for HTTP headers (in the same way we don't have any literal for MongoDB field, all them defined at dbConstants.h).
@fgalan fgalan mentioned this issue Nov 10, 2017
Merged
@jmcanterafonseca jmcanterafonseca changed the title Urhardwire HTTP headers strings Unhardwire HTTP headers strings Dec 8, 2017
@McMutton
Copy link
Contributor

McMutton commented Apr 5, 2018

Hi @fgalan, I can work on this issue.

By the way, if there are any issues that you think I should prioritize over this one, please let me know.

@fgalan
Copy link
Member Author

fgalan commented Apr 5, 2018

Let me have a look... but on the meanwhile, it would be great if you could fix this. I have assigned to you

Thanks!

@fgalan
Copy link
Member Author

fgalan commented Apr 26, 2018

Any news on this @McMutton please?

Just to know... :)

@McMutton
Copy link
Contributor

Hi @fgalan, sorry for the delay, I have just sent the PR for this.

@McMutton McMutton mentioned this issue May 31, 2018
Merged
@fgalan
Copy link
Member Author

fgalan commented May 31, 2018

Implemented in PR #3196

@fgalan fgalan added this to the 1.14.0 milestone May 31, 2018
@fgalan fgalan closed this as completed Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@McMutton McMutton

Labels
good first issue should techdebt
Projects
None yet
Milestone
1.14.0
Development

No branches or pull requests
2 participants
@McMutton @fgalan