Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote not working for complex filters (and maybe in other cases...) #2805

Closed
fgalan opened this issue Jan 11, 2017 · 3 comments
Closed

Quote not working for complex filters (and maybe in other cases...) #2805

fgalan opened this issue Jan 11, 2017 · 3 comments
Assignees
Labels
Milestone

Comments

@fgalan
Copy link
Member

fgalan commented Jan 11, 2017

I have an strong feeling (need to be checked) that the following from NGSIv2 spec (only in WIP version at this moment) http://fiware.github.io/specifications/ngsiv2/latest:

In case some of the tokens include ., you can use single quote (') as separator. For example, the following attribute path 'a.b'.w.'x.y' is composed by three tokens: the first token is a.b, the second token is w and the third token is x.y.

is not actually working.

@fgalan fgalan added this to the 1.7.0 milestone Jan 11, 2017
@kzangeli
Copy link
Member

grep for orionCurl and the ' char doesn't help at all, as most URLs with URI params use the quote to avoid sending the command into background due to the '&' char:

orionCurl --url '/v2/entities?q=S==1&options=keyValues'

However, I did a manual search and found very little:

1595_query_with_q_and_string_values/query_with_q_and_string_values.test:orionCurl --url "/v2/entities?q=A1=='10'"
1595_query_with_q_and_string_values/query_with_q_and_string_values.test:orionCurl --url "/v2/entities?q=A1!='10'"
1595_query_with_q_and_string_values/query_with_q_and_string_values.test:orionCurl --url "/v2/entities?q=A1=='10'x"
1595_query_with_q_and_string_values/query_with_q_and_string_values.test:orionCurl --url "/v2/entities?q=A1=='10'x'"
1129_strings_in_q_uri_param/strings_in_q_uri_param.test:orionCurl --url "/v2/entities?q=S:'123'&options=keyValues"

So, the quote is only used in functests to "make ints be treated as strings".

It seems this feature is completely untested, perhaps not even implemented ...
No worries about duplicating functests :-)

@fgalan
Copy link
Member Author

fgalan commented Jan 12, 2017

Partly implemented in PR #2808

@fgalan
Copy link
Member Author

fgalan commented Jan 12, 2017

Finished (with a comprehesive regresion .test) in PR #2809

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants