Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] "Parse Error" leftover in decription message (ERRORS) #1200

Closed
iariasleon opened this issue Sep 1, 2015 · 3 comments
Closed

[BUG] "Parse Error" leftover in decription message (ERRORS) #1200

iariasleon opened this issue Sep 1, 2015 · 3 comments
Assignees
Milestone

Comments

@iariasleon
Copy link
Contributor

  | error       | BadRequest      

  | description | Parse Error (Invalid characters in entity type)
  | description | Parse Error (Invalid characters in entity id) 
  | description | Parse Error (Invalid characters in attribute name) 
  | description | Parse Error (Invalid characters in attribute value) 
  | description | Parse Error (Invalid characters in attribute value) 
  | description | Parse Error (Invalid characters in metadata name) 
  | description | Parse Error (missing metadata value) 
  | description | Parse Error (Invalid characters in metadata value) 
  | description | Parse Error (Invalid characters in metadata type) 
@iariasleon iariasleon added this to the 0.24.0 milestone Sep 1, 2015
@fgalan
Copy link
Member

fgalan commented Sep 1, 2015

In order to solve this issue, the "Parse Error (...)" should be removed, so the description message only includes for example "Invalid characters in entity type". This is needed due to ParseError is an error in NGSIv2 (see http://telefonicaid.github.io/fiware-orion/api/v2/) reserved for error in the JSON parsint itself, so it is not a good idea to reuse the same words for BadRequest errors.

@fgalan
Copy link
Member

fgalan commented Sep 15, 2015

Fixed in #1236. @iariasleon please have a look and close the issue if you find it ok, please.

@fgalan fgalan assigned iariasleon and unassigned kzangeli Sep 15, 2015
@iariasleon
Copy link
Contributor Author

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants