Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve the ambiguity with structured attribute values #1040

Closed
fgalan opened this issue Jun 26, 2015 · 2 comments
Closed

Solve the ambiguity with structured attribute values #1040

fgalan opened this issue Jun 26, 2015 · 2 comments

Comments

@fgalan
Copy link
Member

fgalan commented Jun 26, 2015

(Originally included as comment in #947)

Finally, it is not part of PR #958 solving the ambiguenty problems for compound attributes e.g.:

What I mean is that for example the following rendering for attribute A1:

"A1": {
  "value": "M1", 
  "type": "a4", 
  "m2": {
    "type": "tm2", 
    "value": "M2"
   }, 
   "m3": 3,
}

Could be interpreted in two different ways:

  • As an attribute without metadata and type and which value is the following JSON object:
{
  "value": "M1", 
  "type": "a4", 
  "m2": {
    "type": "tm2", 
    "value": "M2"
   }, 
   "m3": 3,
}
  • As an attribute of type "a4" and value "M1" with 2 metadata (one named "m2" with type "tm2" and value "M2" and the other named "m3" of type "number" and value 3.
@kzangeli
Copy link
Member

Perhaps we should treat the two cases the exact same way?
I.e. if a user creates an attribute with a compound value and it coincides with 'standard stuff', why not 'assume' it is just 'standard stuff' ?

@fgalan
Copy link
Member Author

fgalan commented Sep 23, 2015

With the new JSON format being worked at #1259, this ambiguity is no longer possible.

@fgalan fgalan closed this as completed Sep 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants