Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CKANSink refactoring caused recvTimeTs go out of range #1947

Open
reitsma opened this issue Oct 6, 2020 · 7 comments
Open

CKANSink refactoring caused recvTimeTs go out of range #1947

reitsma opened this issue Oct 6, 2020 · 7 comments
Labels

Comments

@reitsma
Copy link

reitsma commented Oct 6, 2020

In commit d50030e the CkanSink has been refactoring by moving the aggregation to a generic class. However, an important thing is overlooked: In CKAN the recvTimeTs is in seconds, otherwise it does not fit in the PostgreSQL integer field (4 bytes).

This is before:
NGSIConstants.RECV_TIME_TS + "": "" + recvTimeTs / 1000

After:
aggregation.get(NGSIConstants.RECV_TIME_TS).add(new JsonPrimitive(Long.toString(recvTimeTs)))

@fgalan
Copy link
Member

fgalan commented Oct 7, 2020

Thanks for the report! We'll have a look

CC: @IvanHdzC

@diego-gv
Copy link

Hi all,

I am trying to use CKANSink, but this problem seems to persist.

I am using version 2.11.0 via docker, in any of the following versions has this bug been fixed?

Best regards.

@fgalan
Copy link
Member

fgalan commented Nov 16, 2021

Hi all,

I am trying to use CKANSink, but this problem seems to persist.

I am using version 2.11.0 via docker, in any of the following versions has this bug been fixed?

Best regards.

Looking to the changelog delta from 2.11.0 to 2.14.0 (current release) I see some fixes related with CKAN. Not sure if they include the issue described here, but, anyway, I think is a good idea to test with the last version and, if the issues persists, then fix is there.

@diego-gv could you teset with the newest version and tell us, please? Thanks!

@diego-gv
Copy link

Looking to the changelog delta from 2.11.0 to 2.14.0 (current release) I see some fixes related with CKAN. Not sure if they include the issue described here, but, anyway, I think is a good idea to test with the last version and, if the issues persists, then fix is there.

@diego-gv could you teset with the newest version and tell us, please? Thanks!

Hello @fgalan

It is certainly a good idea and it is the next action we took immediately after posting the comment (build the image of the following versions, as they did not exist) but unfortunately the problem persists.

Regards,

@fgalan
Copy link
Member

fgalan commented Nov 16, 2021

It is certainly a good idea and it is the next action we took immediately after posting the comment (build the image of the following versions, as they did not exist) but unfortunately the problem persists.

Do you mean that you have tested with Cygnus 2.14.0 and the problem persist? (Just to have it fully clear :)

@diego-gv
Copy link

Yes, I tried with newer versions (version 2.14.0 included) but the problem persists.

@fgalan
Copy link
Member

fgalan commented Aug 23, 2022

@diego-gv thanks for your feedback!

By the moment this issue is not in our priorities, but it would be great if somebody in the community would like to have a look and solve it. We could provide support to that effort reviewing the pull request with the fix and giving feedback on it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants