-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tekton task to run linting #954
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
nice one, we may need to tweaks things with a |
tekton/ci-lint.yaml
Outdated
- name: flags | ||
description: flags to use for the test command | ||
- name: version | ||
default: golangci-lint version to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be "description", not default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed 🤦♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bump :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One necessary change needed. @vdemeester
It looks like you want this to live in catalog as well, should it just go straight there? |
@dlorenc let's merge this like the unit test one for now, and we'll refine this from tektoncd/catalog#43 and #964 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 amazing! 🎉
Would you mind adding something to https://github.com/tektoncd/pipeline/tree/master/tekton#tekton-repo-cicd about this? 😇 (Feel free to delete stuff that's already in that doc if it makes sense, I just think it makes sense to have something documenting these Tasks we're adding for the repo and how to run them)
tekton/ci-lint.yaml
Outdated
description: package (and its children) under test | ||
default: github.com/tektoncd/pipeline | ||
- name: flags | ||
description: flags to use for the test command |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this description might not be quite right? ("for the lint command"?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦♂️
a259af0
to
e262f4e
Compare
[`TaskRuns`](https://github.com/tektoncd/pipeline/blob/master/docs/taskruns.md) | ||
and | ||
[`PipelineResources`](https://github.com/tektoncd/pipeline/blob/master/docs/resources.md). | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ty ty! 🎉
e262f4e
to
2776519
Compare
tekton/ci-lint-run.yaml
Outdated
inputs: | ||
params: | ||
- name: flags | ||
value: --verbose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😇 since this is the default we probably don't need it anymore? 😇
This adds a Task to run `golangci-lint` on the repository. This is part of the dogfooding effort on tektoncd/pipeline. Signed-off-by: Vincent Demeester <[email protected]>
This is a work-in-progress, but let's start documenting what are those tasks and what are they used for. Signed-off-by: Vincent Demeester <[email protected]>
2776519
to
5d02815
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/meow space
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold cancel |
/test pull-tekton-pipeline-build-tests |
Changes
This adds a Task to run
golangci-lint
on the repository.This is part of the dogfooding effort on tektoncd/pipeline.
tektoncd/catalog
later on as it's meant to be a reusable task 👼Closes #558
cc @bobcatfish
cc @chmouel I know you'll like it 👼
Signed-off-by: Vincent Demeester [email protected]
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.