Fix step actions documentation #7492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
release-note-none
|
/kind documentation |
vdemeester
reviewed
Dec 15, 2023
It was referencing a TaskSpec in a task which would fail
chmouel
force-pushed
the
fix-documentation
branch
from
ee7871a
to
4d07db6
Compare
tekton-robot
added
size/S
vdemeester
approved these changes
Dec 15, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
Thanks @chmouel!! /lgtm |
|
CI is failing but I am not sure what's going with test-dind-sidecarm, i guess it si because mountvolume is timing out?
/retest |
|
/retest |
|
Created an issue on the example test failures: #7496 |
chitrangpatel
added a commit
to chitrangpatel/pipeline
that referenced
this pull request
Dec 15, 2023
The example test examples/v1/taskruns/dind-sidecar.yaml has been failing in multiple PRs: - tektoncd#7492 (comment) - tektoncd#7494 (comment) - tektoncd#7458 (comment) That example has not been updated in a year. My guess is that the [new image](https://hub.docker.com/layers/library/docker/dind/images/sha256-e8c7a73504adaeff4bab939e8d1f18a6114c99c868b9203a66a42f25aa51e613?context=explore) which was released 16 hours ago (at this point) is causing this. When the image is tagged to the previous version (`docker:24.0.6-dind`) in the taskrun yaml, it executes fine. This PR updates the example test to use the sha256 of the previously working image.This PR fixes tektoncd#7496.
7 tasks
tekton-robot
pushed a commit
that referenced
this pull request
Dec 15, 2023
The example test examples/v1/taskruns/dind-sidecar.yaml has been failing in multiple PRs: - #7492 (comment) - #7494 (comment) - #7458 (comment) That example has not been updated in a year. My guess is that the [new image](https://hub.docker.com/layers/library/docker/dind/images/sha256-e8c7a73504adaeff4bab939e8d1f18a6114c99c868b9203a66a42f25aa51e613?context=explore) which was released 16 hours ago (at this point) is causing this. When the image is tagged to the previous version (`docker:24.0.6-dind`) in the taskrun yaml, it executes fine. This PR updates the example test to use the sha256 of the previously working image.This PR fixes #7496.
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fix step actions documentation
It was referencing a TaskSpec in a task which would fail
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes
/kind documentation