diff --git a/docs/deprecations.md b/docs/deprecations.md index 014066db51a..906ab282678 100644 --- a/docs/deprecations.md +++ b/docs/deprecations.md @@ -24,5 +24,7 @@ being deprecated. | [`Conditions` CRD is deprecated and will be removed. Use `when` expressions instead.](https://github.com/tektoncd/community/blob/main/teps/0007-conditions-beta.md) | [v0.16.0](https://github.com/tektoncd/pipeline/releases/tag/v0.16.0) | Alpha | Nov 02 2020 | | [`PipelineRunCancelled` is deprecated and will be removed](https://github.com/tektoncd/pipeline/issues/4611) | [v0.25.0](https://github.com/tektoncd/pipeline/releases/tag/v0.25.0) | Beta | July 12 2022 | | [`PipelineResources` are deprecated.](https://github.com/tektoncd/community/blob/main/teps/0074-deprecate-pipelineresources.md) | [v0.30.0](https://github.com/tektoncd/pipeline/releases/tag/v0.30.0) | Alpha | Dec 20 2021 | -| [The `PipelineRun.Status.TaskRuns` and `PipelineRun.Status.Runs` fields are deprecated and will be removed.](https://github.com/tektoncd/community/blob/main/teps/0100-embedded-taskruns-and-runs-status-in-pipelineruns.md) | v0.35.0 (to be released) | Beta | Jan 25, 2023 | +| [The `PipelineRun.Status.TaskRuns` and `PipelineRun.Status.Runs` fields are deprecated and will be removed.](https://github.com/tektoncd/community/blob/main/teps/0100-embedded-taskruns-and-runs-status-in-pipelineruns.md) | v0.35.0 | Beta | Jan 25, 2023 | | [PipelineRun.Timeout is deprecated and will be removed](https://github.com/tektoncd/community/blob/main/teps/0046-finallytask-execution-post-timeout.md) | v0.36.0 (to be released) | Beta | Feb 25, 2023 | + +| [Several fields of Task.Step are deprecated](https://github.com/tektoncd/pipeline/issues/4737) | v0.36.0 (to be released) | Beta | Feb 25, 2023 | \ No newline at end of file diff --git a/hack/ignored-openapi-violations.list b/hack/ignored-openapi-violations.list index 44e960bfe7a..af28bcd6cf4 100644 --- a/hack/ignored-openapi-violations.list +++ b/hack/ignored-openapi-violations.list @@ -8,3 +8,24 @@ API rule violation: names_match,github.com/tektoncd/pipeline/pkg/apis/pipeline/v API rule violation: names_match,github.com/tektoncd/pipeline/pkg/apis/pipeline/v1beta1,StepState,ContainerName API rule violation: names_match,github.com/tektoncd/pipeline/pkg/apis/pipeline/v1beta1,TaskRunStatusFields,TaskRunResults API rule violation: names_match,github.com/tektoncd/pipeline/pkg/apis/resource/v1alpha1,PipelineResourceSpec,SecretParams +API rule violation: names_match,github.com/tektoncd/pipeline/pkg/apis/pipeline/v1beta1,Step,DeprecatedLifecycle +API rule violation: names_match,github.com/tektoncd/pipeline/pkg/apis/pipeline/v1beta1,Step,DeprecatedLivenessProbe +API rule violation: names_match,github.com/tektoncd/pipeline/pkg/apis/pipeline/v1beta1,Step,DeprecatedPorts +API rule violation: names_match,github.com/tektoncd/pipeline/pkg/apis/pipeline/v1beta1,Step,DeprecatedReadinessProbe +API rule violation: names_match,github.com/tektoncd/pipeline/pkg/apis/pipeline/v1beta1,Step,DeprecatedStartupProbe +API rule violation: names_match,github.com/tektoncd/pipeline/pkg/apis/pipeline/v1beta1,Step,DeprecatedStdin +API rule violation: names_match,github.com/tektoncd/pipeline/pkg/apis/pipeline/v1beta1,Step,DeprecatedStdinOnce +API rule violation: names_match,github.com/tektoncd/pipeline/pkg/apis/pipeline/v1beta1,Step,DeprecatedTTY +API rule violation: names_match,github.com/tektoncd/pipeline/pkg/apis/pipeline/v1beta1,Step,DeprecatedTerminationMessagePath +API rule violation: names_match,github.com/tektoncd/pipeline/pkg/apis/pipeline/v1beta1,Step,DeprecatedTerminationMessagePolicy +API rule violation: names_match,github.com/tektoncd/pipeline/pkg/apis/pipeline/v1beta1,StepTemplate,DeprecatedLifecycle +API rule violation: names_match,github.com/tektoncd/pipeline/pkg/apis/pipeline/v1beta1,StepTemplate,DeprecatedLivenessProbe +API rule violation: names_match,github.com/tektoncd/pipeline/pkg/apis/pipeline/v1beta1,StepTemplate,DeprecatedName +API rule violation: names_match,github.com/tektoncd/pipeline/pkg/apis/pipeline/v1beta1,StepTemplate,DeprecatedPorts +API rule violation: names_match,github.com/tektoncd/pipeline/pkg/apis/pipeline/v1beta1,StepTemplate,DeprecatedReadinessProbe +API rule violation: names_match,github.com/tektoncd/pipeline/pkg/apis/pipeline/v1beta1,StepTemplate,DeprecatedStartupProbe +API rule violation: names_match,github.com/tektoncd/pipeline/pkg/apis/pipeline/v1beta1,StepTemplate,DeprecatedStdin +API rule violation: names_match,github.com/tektoncd/pipeline/pkg/apis/pipeline/v1beta1,StepTemplate,DeprecatedStdinOnce +API rule violation: names_match,github.com/tektoncd/pipeline/pkg/apis/pipeline/v1beta1,StepTemplate,DeprecatedTTY +API rule violation: names_match,github.com/tektoncd/pipeline/pkg/apis/pipeline/v1beta1,StepTemplate,DeprecatedTerminationMessagePath +API rule violation: names_match,github.com/tektoncd/pipeline/pkg/apis/pipeline/v1beta1,StepTemplate,DeprecatedTerminationMessagePolicy \ No newline at end of file diff --git a/hack/update-openapigen.sh b/hack/update-openapigen.sh index 5740ac3e5f2..6a32ead28e7 100755 --- a/hack/update-openapigen.sh +++ b/hack/update-openapigen.sh @@ -41,7 +41,7 @@ go run k8s.io/kube-openapi/cmd/openapi-gen \ --go-header-file hack/boilerplate/boilerplate.go.txt \ -r "${TMP_DIFFROOT}/api-report" -violations=$(diff --changed-group-format='%>' --unchanged-group-format='' "hack/ignored-openapi-violations.list" "${TMP_DIFFROOT}/api-report" || echo "") +violations=$(diff --changed-group-format='%>' --unchanged-group-format='' <(sort "hack/ignored-openapi-violations.list") <(sort "${TMP_DIFFROOT}/api-report") || echo "") if [ -n "${violations}" ]; then echo "" echo "New API rule violations found which are not present in hack/ignored-openapi-violations.list. Please fix these violations:" diff --git a/pkg/apis/pipeline/v1beta1/container_types.go b/pkg/apis/pipeline/v1beta1/container_types.go index 595e5bf8764..69bc2f20641 100644 --- a/pkg/apis/pipeline/v1beta1/container_types.go +++ b/pkg/apis/pipeline/v1beta1/container_types.go @@ -60,7 +60,7 @@ type Step struct { // +listType=map // +listMapKey=containerPort // +listMapKey=protocol - Ports []corev1.ContainerPort `json:"ports,omitempty" patchStrategy:"merge" patchMergeKey:"containerPort" protobuf:"bytes,6,rep,name=ports"` + DeprecatedPorts []corev1.ContainerPort `json:"ports,omitempty" patchStrategy:"merge" patchMergeKey:"containerPort" protobuf:"bytes,6,rep,name=ports"` // List of sources to populate environment variables in the container. // The keys defined within a source must be a C_IDENTIFIER. All invalid keys // will be reported as an event when the container is starting. When a key exists in multiple @@ -101,16 +101,16 @@ type Step struct { // Cannot be updated. // More info: https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle#container-probes // +optional - LivenessProbe *corev1.Probe `json:"livenessProbe,omitempty" protobuf:"bytes,10,opt,name=livenessProbe"` + DeprecatedLivenessProbe *corev1.Probe `json:"livenessProbe,omitempty" protobuf:"bytes,10,opt,name=livenessProbe"` // Deprecated. This field will be removed in a future release. // Periodic probe of container service readiness. // Container will be removed from service endpoints if the probe fails. // Cannot be updated. // More info: https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle#container-probes // +optional - ReadinessProbe *corev1.Probe `json:"readinessProbe,omitempty" protobuf:"bytes,11,opt,name=readinessProbe"` + DeprecatedReadinessProbe *corev1.Probe `json:"readinessProbe,omitempty" protobuf:"bytes,11,opt,name=readinessProbe"` // Deprecated. This field will be removed in a future release. - // StartupProbe indicates that the Pod has successfully initialized. + // DeprecatedStartupProbe indicates that the Pod has successfully initialized. // If specified, no other probes are executed until this completes successfully. // If this probe fails, the Pod will be restarted, just as if the livenessProbe failed. // This can be used to provide different probe parameters at the beginning of a Pod's lifecycle, @@ -118,12 +118,12 @@ type Step struct { // This cannot be updated. // More info: https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle#container-probes // +optional - StartupProbe *corev1.Probe `json:"startupProbe,omitempty" protobuf:"bytes,22,opt,name=startupProbe"` + DeprecatedStartupProbe *corev1.Probe `json:"startupProbe,omitempty" protobuf:"bytes,22,opt,name=startupProbe"` // Deprecated. This field will be removed in a future release. // Actions that the management system should take in response to container lifecycle events. // Cannot be updated. // +optional - Lifecycle *corev1.Lifecycle `json:"lifecycle,omitempty" protobuf:"bytes,12,opt,name=lifecycle"` + DeprecatedLifecycle *corev1.Lifecycle `json:"lifecycle,omitempty" protobuf:"bytes,12,opt,name=lifecycle"` // Deprecated. This field will be removed in a future release. // Optional: Path at which the file to which the container's termination message // will be written is mounted into the container's filesystem. @@ -133,7 +133,7 @@ type Step struct { // Defaults to /dev/termination-log. // Cannot be updated. // +optional - TerminationMessagePath string `json:"terminationMessagePath,omitempty" protobuf:"bytes,13,opt,name=terminationMessagePath"` + DeprecatedTerminationMessagePath string `json:"terminationMessagePath,omitempty" protobuf:"bytes,13,opt,name=terminationMessagePath"` // Deprecated. This field will be removed in a future release. // Indicate how the termination message should be populated. File will use the contents of // terminationMessagePath to populate the container status message on both success and failure. @@ -143,7 +143,7 @@ type Step struct { // Defaults to File. // Cannot be updated. // +optional - TerminationMessagePolicy corev1.TerminationMessagePolicy `json:"terminationMessagePolicy,omitempty" protobuf:"bytes,20,opt,name=terminationMessagePolicy,casttype=TerminationMessagePolicy"` + DeprecatedTerminationMessagePolicy corev1.TerminationMessagePolicy `json:"terminationMessagePolicy,omitempty" protobuf:"bytes,20,opt,name=terminationMessagePolicy,casttype=TerminationMessagePolicy"` // Image pull policy. // One of Always, Never, IfNotPresent. // Defaults to Always if :latest tag is specified, or IfNotPresent otherwise. @@ -165,7 +165,7 @@ type Step struct { // is not set, reads from stdin in the container will always result in EOF. // Default is false. // +optional - Stdin bool `json:"stdin,omitempty" protobuf:"varint,16,opt,name=stdin"` + DeprecatedStdin bool `json:"stdin,omitempty" protobuf:"varint,16,opt,name=stdin"` // Deprecated. This field will be removed in a future release. // Whether the container runtime should close the stdin channel after it has been opened by // a single attach. When stdin is true the stdin stream will remain open across multiple attach @@ -175,12 +175,12 @@ type Step struct { // flag is false, a container processes that reads from stdin will never receive an EOF. // Default is false // +optional - StdinOnce bool `json:"stdinOnce,omitempty" protobuf:"varint,17,opt,name=stdinOnce"` + DeprecatedStdinOnce bool `json:"stdinOnce,omitempty" protobuf:"varint,17,opt,name=stdinOnce"` // Deprecated. This field will be removed in a future release. - // Whether this container should allocate a TTY for itself, also requires 'stdin' to be true. + // Whether this container should allocate a DeprecatedTTY for itself, also requires 'stdin' to be true. // Default is false. // +optional - TTY bool `json:"tty,omitempty" protobuf:"varint,18,opt,name=tty"` + DeprecatedTTY bool `json:"tty,omitempty" protobuf:"varint,18,opt,name=tty"` // Script is the contents of an executable file to execute. // @@ -219,22 +219,22 @@ func (s *Step) ToK8sContainer() *corev1.Container { Command: s.Command, Args: s.Args, WorkingDir: s.WorkingDir, - Ports: s.Ports, + Ports: s.DeprecatedPorts, EnvFrom: s.EnvFrom, Env: s.Env, Resources: s.Resources, VolumeMounts: s.VolumeMounts, VolumeDevices: s.VolumeDevices, - LivenessProbe: s.LivenessProbe, - ReadinessProbe: s.ReadinessProbe, - StartupProbe: s.StartupProbe, - Lifecycle: s.Lifecycle, - TerminationMessagePath: s.TerminationMessagePath, + LivenessProbe: s.DeprecatedLivenessProbe, + ReadinessProbe: s.DeprecatedReadinessProbe, + StartupProbe: s.DeprecatedStartupProbe, + Lifecycle: s.DeprecatedLifecycle, + TerminationMessagePath: s.DeprecatedTerminationMessagePath, ImagePullPolicy: s.ImagePullPolicy, SecurityContext: s.SecurityContext, - Stdin: s.Stdin, - StdinOnce: s.StdinOnce, - TTY: s.TTY, + Stdin: s.DeprecatedStdin, + StdinOnce: s.DeprecatedStdinOnce, + TTY: s.DeprecatedTTY, } } @@ -245,32 +245,32 @@ func (s *Step) SetContainerFields(c corev1.Container) { s.Command = c.Command s.Args = c.Args s.WorkingDir = c.WorkingDir - s.Ports = c.Ports + s.DeprecatedPorts = c.Ports s.EnvFrom = c.EnvFrom s.Env = c.Env s.Resources = c.Resources s.VolumeMounts = c.VolumeMounts s.VolumeDevices = c.VolumeDevices - s.LivenessProbe = c.LivenessProbe - s.ReadinessProbe = c.ReadinessProbe - s.StartupProbe = c.StartupProbe - s.Lifecycle = c.Lifecycle - s.TerminationMessagePath = c.TerminationMessagePath + s.DeprecatedLivenessProbe = c.LivenessProbe + s.DeprecatedReadinessProbe = c.ReadinessProbe + s.DeprecatedStartupProbe = c.StartupProbe + s.DeprecatedLifecycle = c.Lifecycle + s.DeprecatedTerminationMessagePath = c.TerminationMessagePath s.ImagePullPolicy = c.ImagePullPolicy s.SecurityContext = c.SecurityContext - s.Stdin = c.Stdin - s.StdinOnce = c.StdinOnce - s.TTY = c.TTY + s.DeprecatedStdin = c.Stdin + s.DeprecatedStdinOnce = c.StdinOnce + s.DeprecatedTTY = c.TTY } // StepTemplate is a template for a Step type StepTemplate struct { // Deprecated. This field will be removed in a future release. - // Name of the container specified as a DNS_LABEL. + // DeprecatedName of the container specified as a DNS_LABEL. // Each container in a pod must have a unique name (DNS_LABEL). // Cannot be updated. - Name string `json:"name" protobuf:"bytes,1,opt,name=name"` + DeprecatedName string `json:"name" protobuf:"bytes,1,opt,name=name"` // Docker image name. // More info: https://kubernetes.io/docs/concepts/containers/images // This field is optional to allow higher level config management to default or override @@ -319,7 +319,7 @@ type StepTemplate struct { // +listType=map // +listMapKey=containerPort // +listMapKey=protocol - Ports []corev1.ContainerPort `json:"ports,omitempty" patchStrategy:"merge" patchMergeKey:"containerPort" protobuf:"bytes,6,rep,name=ports"` + DeprecatedPorts []corev1.ContainerPort `json:"ports,omitempty" patchStrategy:"merge" patchMergeKey:"containerPort" protobuf:"bytes,6,rep,name=ports"` // List of sources to populate environment variables in the container. // The keys defined within a source must be a C_IDENTIFIER. All invalid keys // will be reported as an event when the container is starting. When a key exists in multiple @@ -360,16 +360,16 @@ type StepTemplate struct { // Cannot be updated. // More info: https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle#container-probes // +optional - LivenessProbe *corev1.Probe `json:"livenessProbe,omitempty" protobuf:"bytes,10,opt,name=livenessProbe"` + DeprecatedLivenessProbe *corev1.Probe `json:"livenessProbe,omitempty" protobuf:"bytes,10,opt,name=livenessProbe"` // Deprecated. This field will be removed in a future release. // Periodic probe of container service readiness. // Container will be removed from service endpoints if the probe fails. // Cannot be updated. // More info: https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle#container-probes // +optional - ReadinessProbe *corev1.Probe `json:"readinessProbe,omitempty" protobuf:"bytes,11,opt,name=readinessProbe"` + DeprecatedReadinessProbe *corev1.Probe `json:"readinessProbe,omitempty" protobuf:"bytes,11,opt,name=readinessProbe"` // Deprecated. This field will be removed in a future release. - // StartupProbe indicates that the Pod has successfully initialized. + // DeprecatedStartupProbe indicates that the Pod has successfully initialized. // If specified, no other probes are executed until this completes successfully. // If this probe fails, the Pod will be restarted, just as if the livenessProbe failed. // This can be used to provide different probe parameters at the beginning of a Pod's lifecycle, @@ -377,12 +377,12 @@ type StepTemplate struct { // This cannot be updated. // More info: https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle#container-probes // +optional - StartupProbe *corev1.Probe `json:"startupProbe,omitempty" protobuf:"bytes,22,opt,name=startupProbe"` + DeprecatedStartupProbe *corev1.Probe `json:"startupProbe,omitempty" protobuf:"bytes,22,opt,name=startupProbe"` // Deprecated. This field will be removed in a future release. // Actions that the management system should take in response to container lifecycle events. // Cannot be updated. // +optional - Lifecycle *corev1.Lifecycle `json:"lifecycle,omitempty" protobuf:"bytes,12,opt,name=lifecycle"` + DeprecatedLifecycle *corev1.Lifecycle `json:"lifecycle,omitempty" protobuf:"bytes,12,opt,name=lifecycle"` // Deprecated. This field will be removed in a future release. // Optional: Path at which the file to which the container's termination message // will be written is mounted into the container's filesystem. @@ -392,7 +392,7 @@ type StepTemplate struct { // Defaults to /dev/termination-log. // Cannot be updated. // +optional - TerminationMessagePath string `json:"terminationMessagePath,omitempty" protobuf:"bytes,13,opt,name=terminationMessagePath"` + DeprecatedTerminationMessagePath string `json:"terminationMessagePath,omitempty" protobuf:"bytes,13,opt,name=terminationMessagePath"` // Deprecated. This field will be removed in a future release. // Indicate how the termination message should be populated. File will use the contents of // terminationMessagePath to populate the container status message on both success and failure. @@ -402,7 +402,7 @@ type StepTemplate struct { // Defaults to File. // Cannot be updated. // +optional - TerminationMessagePolicy corev1.TerminationMessagePolicy `json:"terminationMessagePolicy,omitempty" protobuf:"bytes,20,opt,name=terminationMessagePolicy,casttype=TerminationMessagePolicy"` + DeprecatedTerminationMessagePolicy corev1.TerminationMessagePolicy `json:"terminationMessagePolicy,omitempty" protobuf:"bytes,20,opt,name=terminationMessagePolicy,casttype=TerminationMessagePolicy"` // Image pull policy. // One of Always, Never, IfNotPresent. // Defaults to Always if :latest tag is specified, or IfNotPresent otherwise. @@ -424,7 +424,7 @@ type StepTemplate struct { // is not set, reads from stdin in the container will always result in EOF. // Default is false. // +optional - Stdin bool `json:"stdin,omitempty" protobuf:"varint,16,opt,name=stdin"` + DeprecatedStdin bool `json:"stdin,omitempty" protobuf:"varint,16,opt,name=stdin"` // Deprecated. This field will be removed in a future release. // Whether the container runtime should close the stdin channel after it has been opened by // a single attach. When stdin is true the stdin stream will remain open across multiple attach @@ -434,63 +434,63 @@ type StepTemplate struct { // flag is false, a container processes that reads from stdin will never receive an EOF. // Default is false // +optional - StdinOnce bool `json:"stdinOnce,omitempty" protobuf:"varint,17,opt,name=stdinOnce"` + DeprecatedStdinOnce bool `json:"stdinOnce,omitempty" protobuf:"varint,17,opt,name=stdinOnce"` // Deprecated. This field will be removed in a future release. - // Whether this container should allocate a TTY for itself, also requires 'stdin' to be true. + // Whether this container should allocate a DeprecatedTTY for itself, also requires 'stdin' to be true. // Default is false. // +optional - TTY bool `json:"tty,omitempty" protobuf:"varint,18,opt,name=tty"` + DeprecatedTTY bool `json:"tty,omitempty" protobuf:"varint,18,opt,name=tty"` } // SetContainerFields sets the fields of the Step to the values of the corresponding fields in the Container func (s *StepTemplate) SetContainerFields(c corev1.Container) { - s.Name = c.Name + s.DeprecatedName = c.Name s.Image = c.Image s.Command = c.Command s.Args = c.Args s.WorkingDir = c.WorkingDir - s.Ports = c.Ports + s.DeprecatedPorts = c.Ports s.EnvFrom = c.EnvFrom s.Env = c.Env s.Resources = c.Resources s.VolumeMounts = c.VolumeMounts s.VolumeDevices = c.VolumeDevices - s.LivenessProbe = c.LivenessProbe - s.ReadinessProbe = c.ReadinessProbe - s.StartupProbe = c.StartupProbe - s.Lifecycle = c.Lifecycle - s.TerminationMessagePath = c.TerminationMessagePath + s.DeprecatedLivenessProbe = c.LivenessProbe + s.DeprecatedReadinessProbe = c.ReadinessProbe + s.DeprecatedStartupProbe = c.StartupProbe + s.DeprecatedLifecycle = c.Lifecycle + s.DeprecatedTerminationMessagePath = c.TerminationMessagePath s.ImagePullPolicy = c.ImagePullPolicy s.SecurityContext = c.SecurityContext - s.Stdin = c.Stdin - s.StdinOnce = c.StdinOnce - s.TTY = c.TTY + s.DeprecatedStdin = c.Stdin + s.DeprecatedStdinOnce = c.StdinOnce + s.DeprecatedTTY = c.TTY } // ToK8sContainer converts the StepTemplate to a Kubernetes Container struct func (s *StepTemplate) ToK8sContainer() *corev1.Container { return &corev1.Container{ - Name: s.Name, + Name: s.DeprecatedName, Image: s.Image, Command: s.Command, Args: s.Args, WorkingDir: s.WorkingDir, - Ports: s.Ports, + Ports: s.DeprecatedPorts, EnvFrom: s.EnvFrom, Env: s.Env, Resources: s.Resources, VolumeMounts: s.VolumeMounts, VolumeDevices: s.VolumeDevices, - LivenessProbe: s.LivenessProbe, - ReadinessProbe: s.ReadinessProbe, - StartupProbe: s.StartupProbe, - Lifecycle: s.Lifecycle, - TerminationMessagePath: s.TerminationMessagePath, + LivenessProbe: s.DeprecatedLivenessProbe, + ReadinessProbe: s.DeprecatedReadinessProbe, + StartupProbe: s.DeprecatedStartupProbe, + Lifecycle: s.DeprecatedLifecycle, + TerminationMessagePath: s.DeprecatedTerminationMessagePath, ImagePullPolicy: s.ImagePullPolicy, SecurityContext: s.SecurityContext, - Stdin: s.Stdin, - StdinOnce: s.StdinOnce, - TTY: s.TTY, + Stdin: s.DeprecatedStdin, + StdinOnce: s.DeprecatedStdinOnce, + TTY: s.DeprecatedTTY, } } diff --git a/pkg/apis/pipeline/v1beta1/openapi_generated.go b/pkg/apis/pipeline/v1beta1/openapi_generated.go index 146dd506b98..bf89f787a11 100644 --- a/pkg/apis/pipeline/v1beta1/openapi_generated.go +++ b/pkg/apis/pipeline/v1beta1/openapi_generated.go @@ -3632,7 +3632,7 @@ func schema_pkg_apis_pipeline_v1beta1_Step(ref common.ReferenceCallback) common. }, "startupProbe": { SchemaProps: spec.SchemaProps{ - Description: "Deprecated. This field will be removed in a future release. StartupProbe indicates that the Pod has successfully initialized. If specified, no other probes are executed until this completes successfully. If this probe fails, the Pod will be restarted, just as if the livenessProbe failed. This can be used to provide different probe parameters at the beginning of a Pod's lifecycle, when it might take a long time to load data or warm a cache, than during steady-state operation. This cannot be updated. More info: https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle#container-probes", + Description: "Deprecated. This field will be removed in a future release. DeprecatedStartupProbe indicates that the Pod has successfully initialized. If specified, no other probes are executed until this completes successfully. If this probe fails, the Pod will be restarted, just as if the livenessProbe failed. This can be used to provide different probe parameters at the beginning of a Pod's lifecycle, when it might take a long time to load data or warm a cache, than during steady-state operation. This cannot be updated. More info: https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle#container-probes", Ref: ref("k8s.io/api/core/v1.Probe"), }, }, @@ -3685,7 +3685,7 @@ func schema_pkg_apis_pipeline_v1beta1_Step(ref common.ReferenceCallback) common. }, "tty": { SchemaProps: spec.SchemaProps{ - Description: "Deprecated. This field will be removed in a future release. Whether this container should allocate a TTY for itself, also requires 'stdin' to be true. Default is false.", + Description: "Deprecated. This field will be removed in a future release. Whether this container should allocate a DeprecatedTTY for itself, also requires 'stdin' to be true. Default is false.", Type: []string{"boolean"}, Format: "", }, @@ -3798,7 +3798,7 @@ func schema_pkg_apis_pipeline_v1beta1_StepTemplate(ref common.ReferenceCallback) Properties: map[string]spec.Schema{ "name": { SchemaProps: spec.SchemaProps{ - Description: "Deprecated. This field will be removed in a future release. Name of the container specified as a DNS_LABEL. Each container in a pod must have a unique name (DNS_LABEL). Cannot be updated.", + Description: "Deprecated. This field will be removed in a future release. DeprecatedName of the container specified as a DNS_LABEL. Each container in a pod must have a unique name (DNS_LABEL). Cannot be updated.", Default: "", Type: []string{"string"}, Format: "", @@ -3986,7 +3986,7 @@ func schema_pkg_apis_pipeline_v1beta1_StepTemplate(ref common.ReferenceCallback) }, "startupProbe": { SchemaProps: spec.SchemaProps{ - Description: "Deprecated. This field will be removed in a future release. StartupProbe indicates that the Pod has successfully initialized. If specified, no other probes are executed until this completes successfully. If this probe fails, the Pod will be restarted, just as if the livenessProbe failed. This can be used to provide different probe parameters at the beginning of a Pod's lifecycle, when it might take a long time to load data or warm a cache, than during steady-state operation. This cannot be updated. More info: https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle#container-probes", + Description: "Deprecated. This field will be removed in a future release. DeprecatedStartupProbe indicates that the Pod has successfully initialized. If specified, no other probes are executed until this completes successfully. If this probe fails, the Pod will be restarted, just as if the livenessProbe failed. This can be used to provide different probe parameters at the beginning of a Pod's lifecycle, when it might take a long time to load data or warm a cache, than during steady-state operation. This cannot be updated. More info: https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle#container-probes", Ref: ref("k8s.io/api/core/v1.Probe"), }, }, @@ -4039,7 +4039,7 @@ func schema_pkg_apis_pipeline_v1beta1_StepTemplate(ref common.ReferenceCallback) }, "tty": { SchemaProps: spec.SchemaProps{ - Description: "Deprecated. This field will be removed in a future release. Whether this container should allocate a TTY for itself, also requires 'stdin' to be true. Default is false.", + Description: "Deprecated. This field will be removed in a future release. Whether this container should allocate a DeprecatedTTY for itself, also requires 'stdin' to be true. Default is false.", Type: []string{"boolean"}, Format: "", }, diff --git a/pkg/apis/pipeline/v1beta1/swagger.json b/pkg/apis/pipeline/v1beta1/swagger.json index c1e8ea1f3e7..f218f3f2a84 100644 --- a/pkg/apis/pipeline/v1beta1/swagger.json +++ b/pkg/apis/pipeline/v1beta1/swagger.json @@ -2042,7 +2042,7 @@ "$ref": "#/definitions/v1.SecurityContext" }, "startupProbe": { - "description": "Deprecated. This field will be removed in a future release. StartupProbe indicates that the Pod has successfully initialized. If specified, no other probes are executed until this completes successfully. If this probe fails, the Pod will be restarted, just as if the livenessProbe failed. This can be used to provide different probe parameters at the beginning of a Pod's lifecycle, when it might take a long time to load data or warm a cache, than during steady-state operation. This cannot be updated. More info: https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle#container-probes", + "description": "Deprecated. This field will be removed in a future release. DeprecatedStartupProbe indicates that the Pod has successfully initialized. If specified, no other probes are executed until this completes successfully. If this probe fails, the Pod will be restarted, just as if the livenessProbe failed. This can be used to provide different probe parameters at the beginning of a Pod's lifecycle, when it might take a long time to load data or warm a cache, than during steady-state operation. This cannot be updated. More info: https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle#container-probes", "$ref": "#/definitions/v1.Probe" }, "stdin": { @@ -2066,7 +2066,7 @@ "$ref": "#/definitions/v1.Duration" }, "tty": { - "description": "Deprecated. This field will be removed in a future release. Whether this container should allocate a TTY for itself, also requires 'stdin' to be true. Default is false.", + "description": "Deprecated. This field will be removed in a future release. Whether this container should allocate a DeprecatedTTY for itself, also requires 'stdin' to be true. Default is false.", "type": "boolean" }, "volumeDevices": { @@ -2195,7 +2195,7 @@ "$ref": "#/definitions/v1.Probe" }, "name": { - "description": "Deprecated. This field will be removed in a future release. Name of the container specified as a DNS_LABEL. Each container in a pod must have a unique name (DNS_LABEL). Cannot be updated.", + "description": "Deprecated. This field will be removed in a future release. DeprecatedName of the container specified as a DNS_LABEL. Each container in a pod must have a unique name (DNS_LABEL). Cannot be updated.", "type": "string", "default": "" }, @@ -2228,7 +2228,7 @@ "$ref": "#/definitions/v1.SecurityContext" }, "startupProbe": { - "description": "Deprecated. This field will be removed in a future release. StartupProbe indicates that the Pod has successfully initialized. If specified, no other probes are executed until this completes successfully. If this probe fails, the Pod will be restarted, just as if the livenessProbe failed. This can be used to provide different probe parameters at the beginning of a Pod's lifecycle, when it might take a long time to load data or warm a cache, than during steady-state operation. This cannot be updated. More info: https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle#container-probes", + "description": "Deprecated. This field will be removed in a future release. DeprecatedStartupProbe indicates that the Pod has successfully initialized. If specified, no other probes are executed until this completes successfully. If this probe fails, the Pod will be restarted, just as if the livenessProbe failed. This can be used to provide different probe parameters at the beginning of a Pod's lifecycle, when it might take a long time to load data or warm a cache, than during steady-state operation. This cannot be updated. More info: https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle#container-probes", "$ref": "#/definitions/v1.Probe" }, "stdin": { @@ -2248,7 +2248,7 @@ "type": "string" }, "tty": { - "description": "Deprecated. This field will be removed in a future release. Whether this container should allocate a TTY for itself, also requires 'stdin' to be true. Default is false.", + "description": "Deprecated. This field will be removed in a future release. Whether this container should allocate a DeprecatedTTY for itself, also requires 'stdin' to be true. Default is false.", "type": "boolean" }, "volumeDevices": { diff --git a/pkg/apis/pipeline/v1beta1/zz_generated.deepcopy.go b/pkg/apis/pipeline/v1beta1/zz_generated.deepcopy.go index 70b62ad2027..43ea81e4520 100644 --- a/pkg/apis/pipeline/v1beta1/zz_generated.deepcopy.go +++ b/pkg/apis/pipeline/v1beta1/zz_generated.deepcopy.go @@ -1465,8 +1465,8 @@ func (in *Step) DeepCopyInto(out *Step) { *out = make([]string, len(*in)) copy(*out, *in) } - if in.Ports != nil { - in, out := &in.Ports, &out.Ports + if in.DeprecatedPorts != nil { + in, out := &in.DeprecatedPorts, &out.DeprecatedPorts *out = make([]v1.ContainerPort, len(*in)) copy(*out, *in) } @@ -1497,23 +1497,23 @@ func (in *Step) DeepCopyInto(out *Step) { *out = make([]v1.VolumeDevice, len(*in)) copy(*out, *in) } - if in.LivenessProbe != nil { - in, out := &in.LivenessProbe, &out.LivenessProbe + if in.DeprecatedLivenessProbe != nil { + in, out := &in.DeprecatedLivenessProbe, &out.DeprecatedLivenessProbe *out = new(v1.Probe) (*in).DeepCopyInto(*out) } - if in.ReadinessProbe != nil { - in, out := &in.ReadinessProbe, &out.ReadinessProbe + if in.DeprecatedReadinessProbe != nil { + in, out := &in.DeprecatedReadinessProbe, &out.DeprecatedReadinessProbe *out = new(v1.Probe) (*in).DeepCopyInto(*out) } - if in.StartupProbe != nil { - in, out := &in.StartupProbe, &out.StartupProbe + if in.DeprecatedStartupProbe != nil { + in, out := &in.DeprecatedStartupProbe, &out.DeprecatedStartupProbe *out = new(v1.Probe) (*in).DeepCopyInto(*out) } - if in.Lifecycle != nil { - in, out := &in.Lifecycle, &out.Lifecycle + if in.DeprecatedLifecycle != nil { + in, out := &in.DeprecatedLifecycle, &out.DeprecatedLifecycle *out = new(v1.Lifecycle) (*in).DeepCopyInto(*out) } @@ -1575,8 +1575,8 @@ func (in *StepTemplate) DeepCopyInto(out *StepTemplate) { *out = make([]string, len(*in)) copy(*out, *in) } - if in.Ports != nil { - in, out := &in.Ports, &out.Ports + if in.DeprecatedPorts != nil { + in, out := &in.DeprecatedPorts, &out.DeprecatedPorts *out = make([]v1.ContainerPort, len(*in)) copy(*out, *in) } @@ -1607,23 +1607,23 @@ func (in *StepTemplate) DeepCopyInto(out *StepTemplate) { *out = make([]v1.VolumeDevice, len(*in)) copy(*out, *in) } - if in.LivenessProbe != nil { - in, out := &in.LivenessProbe, &out.LivenessProbe + if in.DeprecatedLivenessProbe != nil { + in, out := &in.DeprecatedLivenessProbe, &out.DeprecatedLivenessProbe *out = new(v1.Probe) (*in).DeepCopyInto(*out) } - if in.ReadinessProbe != nil { - in, out := &in.ReadinessProbe, &out.ReadinessProbe + if in.DeprecatedReadinessProbe != nil { + in, out := &in.DeprecatedReadinessProbe, &out.DeprecatedReadinessProbe *out = new(v1.Probe) (*in).DeepCopyInto(*out) } - if in.StartupProbe != nil { - in, out := &in.StartupProbe, &out.StartupProbe + if in.DeprecatedStartupProbe != nil { + in, out := &in.DeprecatedStartupProbe, &out.DeprecatedStartupProbe *out = new(v1.Probe) (*in).DeepCopyInto(*out) } - if in.Lifecycle != nil { - in, out := &in.Lifecycle, &out.Lifecycle + if in.DeprecatedLifecycle != nil { + in, out := &in.DeprecatedLifecycle, &out.DeprecatedLifecycle *out = new(v1.Lifecycle) (*in).DeepCopyInto(*out) }