TEP-0090: Matrix - Parameters
#4704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
release-note
|
The following is the coverage report on the affected files.
|
jerop
force-pushed
the
tep-0090-parameters
branch
from
2151532
to
fb34973
Compare
|
The following is the coverage report on the affected files.
|
ghost
reviewed
Mar 23, 2022
jerop
force-pushed
the
tep-0090-parameters
branch
from
fb34973
to
ce79c8b
Compare
[TEP-0090][tep-0090] proposed executing a `PipelineTask` in parallel `TaskRuns` and `Runs` with substitutions from combinations of `Parameters` in a `Matrix`. In this change, we add validation for `Parameters` including: - `Parameter` must be of type `Array` - `Parameter` must be in one of `matrix` or `params`, not both - `Parameter` in `Matrix` must exist in `Parameters` declarations in `Pipeline` [tep-0090]: https://github.com/tektoncd/community/blob/main/teps/0090-matrix.md
jerop
force-pushed
the
tep-0090-parameters
branch
from
ce79c8b
to
46af2b7
Compare
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
|
/lgtm Cheers @jerop! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
This was referenced Mar 23, 2022
5 tasks
jerop
added a commit
to jerop/pipeline
that referenced
this pull request
May 9, 2022
… Reconciler The `TaskRun` reconciler validates that the needed `Parameters` are provided, no extra `Parameters` are provide and the types of `Parameters` are matching. Prior to this change, the reconciler did the above validation considering the `params` field in the `PipelineTask` only. In this change, we include `matrix` field into the validation routine described above. This includes validating that `Parameters` in the `Matrix` are substituting `Parameters` of type `String` in the underlying `Task`. Related: - tektoncd#4704 - tektoncd#4841
jerop
added a commit
to jerop/pipeline
that referenced
this pull request
May 9, 2022
… Reconciler The `TaskRun` reconciler validates that the needed `Parameters` are provided, no extra `Parameters` are provide and the types of `Parameters` are matching. Prior to this change, the reconciler did the above validation considering the `params` field in the `PipelineTask` only. In this change, we include `matrix` field into the validation routine described above. This includes validating that `Parameters` in the `Matrix` are substituting `Parameters` of type `String` in the underlying `Task`. Related: - tektoncd#4704 - tektoncd#4841
tekton-robot
pushed a commit
that referenced
this pull request
May 11, 2022
… Reconciler The `TaskRun` reconciler validates that the needed `Parameters` are provided, no extra `Parameters` are provide and the types of `Parameters` are matching. Prior to this change, the reconciler did the above validation considering the `params` field in the `PipelineTask` only. In this change, we include `matrix` field into the validation routine described above. This includes validating that `Parameters` in the `Matrix` are substituting `Parameters` of type `String` in the underlying `Task`. Related: - #4704 - #4841
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
TEP-0090 proposed executing a
PipelineTaskin parallelTaskRunsandRunswith substitutions from combinations ofParametersin aMatrix.In this change, we add validation for
Parametersincluding:Parametermust be of typeArrayParametermust be in one ofmatrixorparams, not bothParameterinMatrixmust exist inParametersdeclarations inPipeline/kind feature
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes