Use tektoncd/results repo for git-init symbolic ref tests #4038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit we were pointing one of our integration tests at a Spring project repo. We did this to test our git-init code with a repo that uses "main" as its main branch instead of "master". Now that we have switched many/all of our repos over to "main" instead of "master" we can use them for testing instead. This means we haven't tied our tests to an external third party repo that might change / be removed without our realizing it.
tekton-robot
added
release-note-none
tekton-robot
added
the
size/XS
jerop
approved these changes
Jun 14, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
sounds good, thanks @sbwsg /lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #2854
Prior to this commit we were pointing one of our integration tests
at a Spring project repo. We did this to test our git-init code
with a repo that uses "main" as its main branch instead of "master".
Now that we have switched many/all of our repos over to "main"
instead of "master" we can use them for testing instead. This means
we haven't tied our tests to an external third party repo that might
change / be removed without our realizing it.
/kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes