Remove creds-init image from build and deploy #3665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the creds-init source code and image from Pipelines. The source and image have not been in use for several releases and so the code is effectively dead. Along with the removal of source a number of other changes have been made: - references to "creds-init" in doc strings have been updated with more verbose descriptions. Now that creds-init is not a source directory any more I figure it is helpful to add the extra context for future developers who may not know what "creds-init" refers to. - CredsImage has been removed from the pipeline.Images struct and all uses of that field have been nixed.
tekton-robot
added
release-note
tekton-robot
added
the
size/L
|
I can't see the failed test in the integration log. I've spot-checked a few of these tests locally and haven't seen any errors. Re-running to see if the failures reproduce. /test pull-tekton-pipeline-integration-tests /test check-pr-has-kind-label |
ghost
added
kind/cleanup
vdemeester
approved these changes
Jan 8, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This commit removes the creds-init source code and image from Pipelines. The source
and image have not been in use for several releases and so the code is effectively
dead.
Along with the removal of source a number of other changes have been made:
references to "creds-init" in doc strings have been updated with more verbose
descriptions. Now that creds-init is not a source directory any more I figure it
is helpful to add the extra context for future developers who may not know what
"creds-init" refers to.
CredsImage has been removed from the pipeline.Images struct and all uses of
that field have been nixed.
Fixes #3457
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes
/kind cleanup