build: run ko resolve on build presubmit 🙃 #3621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
release-note
tekton-robot
added
the
size/XS
4 tasks
ghost
reviewed
Dec 9, 2020
test/presubmit-tests.sh
Outdated
| @@ -57,9 +57,15 @@ function check_yaml_lint() { | |||
| results_banner "YAML Lint" 0 | |||
| } | |||
|
|
|||
| function ko_resolve() { | |||
| oci_layout_path=$(mktemp -d) | |||
| ko reslove --push=false --oci-layout-path=${oci_layout_path} -f config | |||
vdemeester
force-pushed
the
run-ko-resolve-on-build
branch
from
0de256f to
ce6ce67
Compare
ghost
approved these changes
Dec 9, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbwsg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
vdemeester
force-pushed
the
run-ko-resolve-on-build
branch
from
ce6ce67 to
b5b3ecb
Compare
imjasonh
requested changes
Dec 9, 2020
vdemeester
force-pushed
the
run-ko-resolve-on-build
branch
2 times, most recently
from
037690a to
91f2400
Compare
|
/hold |
tekton-robot
added
the
do-not-merge/hold
vdemeester
force-pushed
the
run-ko-resolve-on-build
branch
from
91f2400 to
b9909d3
Compare
|
Nice! This is much easier than the other approach I was going to try. |
This run `ko resolve` when doing the presubmit build to be able to detect any potential "multi-arch" problem with the PRs content. `ko resolve` is used in our publish pipeline. Signed-off-by: Vincent Demeester <[email protected]>
vdemeester
force-pushed
the
run-ko-resolve-on-build
branch
from
b9909d3 to
308cf1f
Compare
|
/test all |
|
/test pull-tekton-pipeline-build-tests |
|
/test pull-tekton-pipeline-integration-tests |
|
/test all |
|
/lgtm Looking Good! 🤙🏽 |
|
/hold cancel |
tekton-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This run
ko resolvewhen doing the presubmit build to be able todetect any potential "multi-arch" problem with the PRs content.
ko resolveis used in our publish pipeline.Signed-off-by: Vincent Demeester [email protected]
/kind misc
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes