Mark PipelienResourceBinding as inlined 🏑

[vdemeester]

Changes

Without this, using Unstructured to unmarshall the structs will
result in empty/nil resources.

This is a problem for tektoncd/cli v1beta1 support 😓. Should we consider it for a 0.11.2 ?

/cc @sbwsg @bobcatfish

Signed-off-by: Vincent Demeester [email protected]

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

• If you are adding a new binary/image to the cmd dir, please update
  the release Task to build and release this image.

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

Fix embedded PipelineResourceBinding json unmarshalling

[vdemeester]

/cc @piyush-garg

[ghost]

I don't fully understand what's going on here. Unstructured is this type from k8s right? And inline I found documented in the bson package but not json, it means that json fields don't need to be nested in order for their values to end up in the embedded struct, is that right?

So at the moment when cli unmarshals TaskResourceBinding into an Unstructured variable, we lose PipelineResourceBinding - it gets set to nil. Is that right?

/approve

[vdemeester]

I don't fully understand what's going on here. Unstructured is this type from k8s right? And inline I found documented in the bson package but not json, it means that json fields don't need to be nested in order for their values to end up in the embedded struct, is that right?

inline for some of the go marshalling json library, means this is a embedded type, the fields from it are at the same level as the field. Which is the case here (and for other field in the API).

So at the moment when cli unmarshals TaskResourceBinding into an Unstructured variable, we lose PipelineResourceBinding - it gets set to nil. Is that right?

/approve

yes

[piyush-garg]

/lgtm

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: piyush-garg, sbwsg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sbwsg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vdemeester]

/retest

[vdemeester]

/retest

[vdemeester]

/retest

[ghost]

/test pull-tekton-pipeline-integration-tests

[piyush-garg]

This will need for tektoncd/cli#884 to work properly

[piyush-garg]

/test pull-tekton-pipeline-integration-tests

[vdemeester]

/test pull-tekton-pipeline-integration-tests

[ghost]

I'm pretty sure these failures are #2337

[vdemeester]

/test pull-tekton-pipeline-integration-tests

[ghost]

looks like this should pass after a rebase! the integration failed on the pipelinerun cancel e2e test we merged earlier today.

[piyush-garg]

/lgtm