Fix release pipeline to handle #1122

[afrittoli]

Since #1122, we do not treat outputs that were inputs as well in any
special way, meaning that the output folder will be empty unless we
copy the input to the output.

Fix the release pipeline to handle that.

Fixes: #1325

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

• If you are adding a new binary/image to the cmd dir, please update
  the release Task and TaskRun to build and release this image

Reviewer Notes

If API changes
are included, additive changes
must be approved by at least two OWNERS
and backwards incompatible changes
must be approved by more than 50% of the OWNERS,
and they must first be added
in a backwards compatible way.

Release Notes

Describe any user facing changes here, or delete this block.

Examples of user facing changes:
- API changes
- Bug fixes
- Any changes in behavior

[dibyom]

/lgtm

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli, dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [afrittoli,dibyom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[bobcatfish]

Just a quick note that the release pipeline (afaik - maybe this is changed now?) should be running against v0.3.1 of Tekton (https://github.com/tektoncd/pipeline/tree/master/tekton#install-tekton) - tho it's good to be ready for this change later!

[dibyom]

Do the nightly and release jobs run on the same cluster?

[afrittoli]

Do the nightly and release jobs run on the same cluster?

I'm not sure if they do, but at least I could verify that Tekton in the prow cluster in tekton-releases runs on version 0.3.1. Which means I should not update the release pipeline before running the release.

We could perhaps have a parameter added to the publish Task to conditionally handle the change introduced #1122, so that the pipeline may work both on pre and post v0.7.0.

BTW the only way I cound find out the version of Tekton was to compare the image sha from the controller pod in the cluster with the sha from the 0.3.1 release file on github. Is there any better way to find out about the version of Tekton that runs in the cluster?

[dibyom]

+1 I like the parameter idea. Though it would have been cool to have a conditional that checks the version of Tekton and then runs the right task :)