Support Condition only resources in PipelineTask #1270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
tekton-robot
added
approved
|
The following is the coverage report on pkg/.
|
ghost
approved these changes
Sep 4, 2019
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom, sbwsg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/test pull-tekton-pipeline-build-tests |
This commit fixes the Pipeline validation logic to account for resources that are declared in a `PipelineTaskCondition` but not in a `PipelineTask`. Previously, each resource used in a `PipelineTaskCondition` also had to be declared in the `PipelineTask`. Fixes tektoncd#1263 Signed-off-by: Dibyo Mukherjee <[email protected]>
dibyom
force-pushed
the
cond-only-resources
branch
from
be9cc3e
to
d926da4
Compare
|
The following is the coverage report on pkg/.
|
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This commit fixes the Pipeline validation logic to account
for resources that are declared in a
PipelineTaskConditionbutnot in a
PipelineTask. Previously, each resource used in aPipelineTaskConditionalso had to be declared in thePipelineTask.Fixes #1263
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them: