Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flake: TestLargerResultsSidecarLogs is flaky #6769

Closed
JeromeJu opened this issue Jun 2, 2023 · 8 comments
Closed

Flake: TestLargerResultsSidecarLogs is flaky #6769

JeromeJu opened this issue Jun 2, 2023 · 8 comments
Assignees
Labels
kind/flake Categorizes issue or PR as related to a flakey test

Comments

@JeromeJu
Copy link
Member

JeromeJu commented Jun 2, 2023

The PipelienRun times out after waiting for 10 minutes.

Prow logs: https://prow.tekton.dev/view/gs/tekton-prow/pr-logs/pull/tektoncd_pipeline/6766/pull-tekton-pipeline-alpha-integration-tests/1664713403156926464

logs

/kind flake

@tekton-robot tekton-robot added the kind/flake Categorizes issue or PR as related to a flakey test label Jun 2, 2023
@EmmaMunley
Copy link
Contributor

Also saw this in #6792 and was able to reproduce locally even when on main. Here are the logs from my cluster: https://gist.github.com/EmmaMunley/5f0a056b410bbb6ef7dc41e08e62c2f7

@chitrangpatel
Copy link
Contributor

chitrangpatel commented Jun 13, 2023

I did some digging around and found this:
For @JeromeJu 's error, I think it had trouble fetching the alpine image. I don't think its an error with larger results. Rather than it being a flake with larger results, it must have been a flake with the docker registry pulling the alpine image used in the test.

https://gist.github.com/JeromeJu/d19845cfac2f69d83d33c3ee385ca0cf#file-gistfile1-txt-L303-L313

For @EmmaMunley's bug, do you have access to your controller's logs? My guess is that when you were testing this on your local cluster, you did not enable access to the logs by kubectl apply -f optional_config/enable-log-access-to-controller and so the controller must have not been able to fetch the sidecar logs to extract the results and therefore the next task could not access them leading to the failure in your logs.

@tekton-robot
Copy link
Collaborator

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 11, 2023
@tekton-robot
Copy link
Collaborator

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 11, 2023
@afrittoli
Copy link
Member

/remove-lifecycle rotten

@tekton-robot tekton-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Oct 31, 2023
@JeromeJu
Copy link
Member Author

/assign

@JeromeJu
Copy link
Member Author

@chitrangpatel Thanks for the clarification! It looks like we could close this for now unless anything other than pull issue or the feature setup, WDYT?

@chitrangpatel
Copy link
Contributor

@chitrangpatel Thanks for the clarification! It looks like we could close this for now unless anything other than pull issue or the feature setup, WDYT?

Agreed. We can close this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/flake Categorizes issue or PR as related to a flakey test
Projects
None yet
Development

No branches or pull requests

5 participants