Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPIRE Integration also needs to sign ResolutionRequest's status and PipelineRun's status #5474

Open
chuangw6 opened this issue Sep 12, 2022 · 5 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@chuangw6
Copy link
Member

chuangw6 commented Sep 12, 2022

Feature request

The TEP-0089 only mentions the importance of signing the content of TaskRun's status.

When integrating SPIRE, we also need to sign remote ResolutionRequest's status and PipelineRun's status.

Use case

  • ResolutionRequest's status

ResolutionRequest Status contains 2 important pieces of data: status.data and status.source. status.data is the place to store the original remote content resolved by the remote resolution controller, and status.source is the place to record the source information where the remote resource came from.
Therefore, we need to sign the status content to make sure both status.data and status.source is trustful.

  • PipelineRun's status

Similar to TaskRun status, PipelineRun status contains important information as well i.e. status.childReferences, status.taskruns and status.provenance.

To generate pipelinerun level provenance, Chains just looks up the status of PipelineRun CRD. Therefore, we need to guarantee the integrity there as well.

@chuangw6 chuangw6 added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 12, 2022
@chuangw6
Copy link
Member Author

chuangw6 commented Sep 12, 2022

@lumjjb
Copy link
Contributor

lumjjb commented Sep 12, 2022

The SPIRE mechanisms are a great fit for these use cases!

@pxp928
Copy link
Member

pxp928 commented Sep 12, 2022

Let me know how I can help with this. Great use cases.

@tekton-robot
Copy link
Collaborator

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 14, 2023
@afrittoli
Copy link
Member

This feels like something that should be frozen!
/lifecycle frozen

@tekton-robot tekton-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
Status: Todo
Development

No branches or pull requests

5 participants