Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove creds-init binary from Pipelines builds #3457

Closed
ghost opened this issue Oct 26, 2020 · 0 comments · Fixed by #3665
Closed

Remove creds-init binary from Pipelines builds #3457

ghost opened this issue Oct 26, 2020 · 0 comments · Fixed by #3665
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Milestone
Pipelines v0.20

Comments

@ghost
Copy link

ghost commented Oct 26, 2020

Change Request

We still build a binary called creds-init even though it's no longer used by any of our pipeline or taskrun code. This Issue addresses the removal of the cmd/creds-init directory along with any associated build steps / tasks / params.

It looks like the phrase "creds-init" appears in the following places:

./tekton/koparse/test_release.yaml
./tekton/koparse/test_koparse.py
./tekton/koparse/test_koparse.py
./tekton/resources.yaml
./tekton/resources.yaml
./tekton/release-cheat-sheet.md

So all these should be updated.
@ghost ghost added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Oct 26, 2020
@vdemeester vdemeester added this to the Pipelines v0.20 milestone Nov 30, 2020
@vdemeester vdemeester removed the priority/backlog Higher priority than priority/awaiting-more-evidence. label Nov 30, 2020
@ghost ghost mentioned this issue Jan 7, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
Pipelines v0.20
Development

Successfully merging a pull request may close this issue.

Remove creds-init image from build and deploy
1 participant
@vdemeester