-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify git-init symbolic ref test to use tektoncd-owned repo or similar #2854
Comments
Rotten issues close after 30d of inactivity. /close Send feedback to tektoncd/plumbing. |
Stale issues rot after 30d of inactivity. /lifecycle rotten Send feedback to tektoncd/plumbing. |
@tekton-robot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/remove-lifecycle rotten |
@vdemeester: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issues go stale after 90d of inactivity. /lifecycle stale Send feedback to tektoncd/plumbing. |
/remove-lifecycle stale |
Issues go stale after 90d of inactivity. /lifecycle stale Send feedback to tektoncd/plumbing. |
Stale issues rot after 30d of inactivity. /lifecycle rotten Send feedback to tektoncd/plumbing. |
/remove-lifecycle rotten This would still be a nice-to-have. Now that we've switched many/most/all of our repos over to "main" branch I think any of them could be a good candidate. |
Issues go stale after 90d of inactivity. /lifecycle stale Send feedback to tektoncd/plumbing. |
/remove-lifecycle stale |
Expected Behavior
Our tests rely on resources that are directly under the
tektoncd
org's control so that changes outside our control do not negatively affect test results.Actual Behavior
The git-init symbolic ref test introduced in #2835 (
test/git_checkout_test.go
andtest/v1alpha1/git_checkout_test.go
) currently relies on an outside repo,https://github.com/spring-projects/spring-petclinic
. This is done because spring-petclinic uses an atypical default branch of "main" instead of the more typical "master".Additional Info
There are a couple of solutions to this problem:
tektoncd
org that also uses an atypical default branch name.The text was updated successfully, but these errors were encountered: