Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Tasks/Pipelines to indicate versions of Tekton Pipelines they work with #2588

Closed
bobcatfish opened this issue May 8, 2020 · 2 comments
Assignees
Labels
area/api Indicates an issue or PR that deals with the API. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@bobcatfish
Copy link
Collaborator

Expected Behavior

Before I try to use a Task or a Pipeline, I should know if it is compatible with my installation of Tekton Pipelines just by looking at it.

Actual Behavior

Right now the only indication is the apiVersion, currently with possible values of v1alpha1 and v1beta1. But additive changes can be made between releases.

Steps to Reproduce the Problem

For example v0.12.0 introduces Pipeline level results, which are not present in v0.11.0, although they are both v1beta1. This means that defining a Pipeline which declares results and trying to use it against a v0.11.0 installation will fail. (We could work around this by allowing versions to ignore fields they don't recognize, but even in that case the expected behavior would not be present.)

Additional Info

@bobcatfish bobcatfish added area/api Indicates an issue or PR that deals with the API. kind/feature Categorizes issue or PR as related to a new feature. labels May 8, 2020
@bobcatfish
Copy link
Collaborator Author

Proposal for using annotations in this design doc.

@bobcatfish
Copy link
Collaborator Author

We've started using the tekton.dev/minVersion annotation in tektoncd/catalog#389.

Seems okay to close this issue now then :D We could still have the controller fail if the minVersion is > than it's own version but that's another story.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Indicates an issue or PR that deals with the API. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants