Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide short term solution for array "star" substitution #2041

Closed
skaegi opened this issue Feb 12, 2020 · 2 comments · Fixed by #2085
Closed

Provide short term solution for array "star" substitution #2041

skaegi opened this issue Feb 12, 2020 · 2 comments · Fixed by #2085
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@skaegi
Copy link
Contributor

skaegi commented Feb 12, 2020

We want to eventually just use JSONPath for variable expansion but in the short-term we should just add an extra star expansion for array types for our string-prefix based expansion. e.g. params.myarray will cause the create "both" a params.myarray and params.myarray[*] map key for ApplyArrayReplacements and the various validate methods.

This will let us update our tests to use the star-expansion in advance of jsonpath support.

@skaegi
Copy link
Contributor Author

skaegi commented Feb 12, 2020

/assign

@dibyom
Copy link
Member

dibyom commented Feb 13, 2020

/kind feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants