You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
TaskRun→Pod and PodStatus→TaskRunStatus translation code should be organized into its own package, ideally with minimal exported symbols.
This would make it easier to test and use in isolation: the TaskRun reconciler would simply be able to call pod.MakePod(taskRun) and create the correct Pod for the TaskRun, without being exposed to any details of what that even entails.
Actual Behavior
MakePod is buried among dozens of exported methods in pkg/reconciler/taskrun/resources, which also contains code for PipelineResources.
TaskRun→Pod translation also includes entrypoint rewriting and copy step injection, which has leaked into taskrun.go.
PodStatus→TaskRunStatus translation is in a separate package, in status.UpdateStatusFromPod, which happens to unnecessarily take a kubeclient.
/assign
/kind cleanup
The text was updated successfully, but these errors were encountered:
imjasonh
added
the
kind/cleanup
Categorizes issue or PR as related to cleaning up code, process, or technical debt.
label
Nov 4, 2019
Expected Behavior
TaskRun→Pod and PodStatus→TaskRunStatus translation code should be organized into its own package, ideally with minimal exported symbols.
This would make it easier to test and use in isolation: the TaskRun reconciler would simply be able to call
pod.MakePod(taskRun)
and create the correct Pod for the TaskRun, without being exposed to any details of what that even entails.Actual Behavior
MakePod
is buried among dozens of exported methods inpkg/reconciler/taskrun/resources
, which also contains code for PipelineResources.TaskRun→Pod translation also includes entrypoint rewriting and copy step injection, which has leaked into taskrun.go.
PodStatus→TaskRunStatus translation is in a separate package, in
status.UpdateStatusFromPod
, which happens to unnecessarily take akubeclient
./assign
/kind cleanup
The text was updated successfully, but these errors were encountered: