Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change serviceAccount to serviceAccountName to be consistent with k8s #1219

Closed
EliZucker opened this issue Aug 19, 2019 · 2 comments · Fixed by #1291 or #1618
Closed

Change serviceAccount to serviceAccountName to be consistent with k8s #1219

EliZucker opened this issue Aug 19, 2019 · 2 comments · Fixed by #1291 or #1618
Assignees
@vdemeester
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. kind/question Issues or PRs that are questions around the project or a particular feature
Milestone
Pipelines 0.9 🐱

Comments

@EliZucker
Copy link
Member

The serviceAccount field name should probably be renamed to serviceAccountName to match more closely with the normal k8s API. See serviceAccountName under pod here.

This stems from @bobcatfish 's comment here: https://github.com/tektoncd/triggers/pull/63/files#r314863023

ugh but it's called serviceAccountName in the rest of kubernetes isn't it :S

image

maybe we should leave this and change pipelines after all
@EliZucker EliZucker mentioned this issue Aug 19, 2019
Merged
3 tasks
@vdemeester
Copy link
Member

I'm ok with renaming it — I swear I saw serviceAccountName somewhere, at some point, in pipeline 👼
If we go for it, we need to do it in a backward compatible way 👼

@vdemeester vdemeester added kind/feature Categorizes issue or PR as related to a new feature. kind/question Issues or PRs that are questions around the project or a particular feature labels Aug 20, 2019
@bobcatfish bobcatfish added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Aug 20, 2019
@bobcatfish bobcatfish added this to the Pipelines 0.7 🐱 milestone Aug 20, 2019
@bobcatfish bobcatfish mentioned this issue Aug 20, 2019
Closed
@dibyom dibyom mentioned this issue Sep 5, 2019
Merged
3 tasks
@fraenkel fraenkel mentioned this issue Sep 8, 2019
Merged
3 tasks
@bobcatfish
Copy link
Collaborator

Re-opening b/c afaik we made the backwards compatible change, but not the backwards incompatible one.

@bobcatfish bobcatfish reopened this Nov 4, 2019
@vdemeester vdemeester mentioned this issue Nov 26, 2019
Merged
3 tasks
@soukron soukron mentioned this issue Apr 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vdemeester vdemeester

Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. kind/question Issues or PRs that are questions around the project or a particular feature
Projects
None yet
Milestone
Pipelines 0.9 🐱
4 participants
@vdemeester @bobcatfish @afrittoli @EliZucker