fixing CI for 0.42

In PR #6201, we identified a failure with our CI system. Beta integrations tests are failing in PR #6201. Our CI system has been updated to run beta tests but the code base in release-v0.42.x was not updated with necessary changes to run beta tests successfully. We discovered a list of PRs which needs to be cherry picked into release-0.42.x branch for the tests to work. Cherry picking the following PRs: [upgrade test] Change to Kind cluster and Unfixed upgrade test release version #5726 Add prow env for beta integration test #5737 Beta Example Tests #6031 Signed-off-by: pritidesai <[email protected]>
tektoncd · Feb 27, 2023 · c14adc6 · c14adc6
1 parent 99d0746
commit c14adc6
Show file tree

Hide file tree

Showing 32 changed files with 104 additions and 96 deletions.
diff --git a/cmd/entrypoint/runner.go b/cmd/entrypoint/runner.go
@@ -8,7 +8,7 @@ Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
 You may obtain a copy of the License at
 
-    http://www.apache.org/licenses/LICENSE-2.0
+	http://www.apache.org/licenses/LICENSE-2.0
 
 Unless required by applicable law or agreed to in writing, software
 distributed under the License is distributed on an "AS IS" BASIS,

diff --git a/cmd/git-init/main.go b/cmd/git-init/main.go
@@ -5,7 +5,7 @@ Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
 You may obtain a copy of the License at
 
-    http://www.apache.org/licenses/LICENSE-2.0
+	http://www.apache.org/licenses/LICENSE-2.0
 
 Unless required by applicable law or agreed to in writing, software
 distributed under the License is distributed on an "AS IS" BASIS,

diff --git a/cmd/imagedigestexporter/main.go b/cmd/imagedigestexporter/main.go
@@ -33,7 +33,9 @@ var (
 	terminationMessagePath = flag.String("terminationMessagePath", "/tekton/termination", "Location of file containing termination message")
 )
 
-/* The input of this go program will be a JSON string with all the output PipelineResources of type
+/*
+	The input of this go program will be a JSON string with all the output PipelineResources of type
+
 Image, which will include the path to where the index.json file will be located. The program will
 read the related index.json file(s) and log another JSON string including the name of the image resource
 and the digests.

diff --git a/cmd/pullrequest-init/main.go b/cmd/pullrequest-init/main.go
@@ -5,7 +5,7 @@ Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
 You may obtain a copy of the License at
 
-    http://www.apache.org/licenses/LICENSE-2.0
+	http://www.apache.org/licenses/LICENSE-2.0
 
 Unless required by applicable law or agreed to in writing, software
 distributed under the License is distributed on an "AS IS" BASIS,

diff --git a/docs/pipeline-api.md b/docs/pipeline-api.md
@@ -13824,7 +13824,7 @@ string
 <h3 id="tekton.dev/v1beta1.CustomRunStatus">CustomRunStatus
 </h3>
 <p>
-(<em>Appears on:</em><a href="#tekton.dev/v1beta1.CustomRun">CustomRun</a>)
+(<em>Appears on:</em><a href="#tekton.dev/v1beta1.CustomRun">CustomRun</a>, <a href="#tekton.dev/v1beta1.CustomRunStatusFields">CustomRunStatusFields</a>)
 </p>
 <div>
 <p>CustomRunStatus defines the observed state of CustomRun</p>

diff --git a/pkg/apis/pipeline/pod/template.go b/pkg/apis/pipeline/pod/template.go
@@ -148,6 +148,7 @@ func (tpl *Template) ToAffinityAssistantTemplate() *AffinityAssistantTemplate {
 }
 
 // PodTemplate holds pod specific configuration
+//
 //nolint:revive
 type PodTemplate = Template
 

diff --git a/pkg/apis/pipeline/v1/container_types.go b/pkg/apis/pipeline/v1/container_types.go
@@ -5,7 +5,7 @@ Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
 You may obtain a copy of the License at
 
-    http://www.apache.org/licenses/LICENSE-2.0
+	http://www.apache.org/licenses/LICENSE-2.0
 
 Unless required by applicable law or agreed to in writing, software
 distributed under the License is distributed on an "AS IS" BASIS,

diff --git a/pkg/apis/pipeline/v1/taskrun_defaults_test.go b/pkg/apis/pipeline/v1/taskrun_defaults_test.go
@@ -5,7 +5,7 @@ Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
 You may obtain a copy of the License at
 
-    http://www.apache.org/licenses/LICENSE-2.0
+	http://www.apache.org/licenses/LICENSE-2.0
 
 Unless required by applicable law or agreed to in writing, software
 distributed under the License is distributed on an "AS IS" BASIS,

diff --git a/pkg/apis/pipeline/v1beta1/resource_types_validation.go b/pkg/apis/pipeline/v1beta1/resource_types_validation.go
@@ -73,9 +73,9 @@ func (tr *TaskRunResources) Validate(ctx context.Context) *apis.FieldError {
 }
 
 // validateTaskRunResources validates that
-//	1. resource is not declared more than once
-//	2. if both resource reference and resource spec is defined at the same time
-//	3. at least resource ref or resource spec is defined
+//  1. resource is not declared more than once
+//  2. if both resource reference and resource spec is defined at the same time
+//  3. at least resource ref or resource spec is defined
 func validateTaskRunResources(ctx context.Context, resources []TaskResourceBinding, path string) *apis.FieldError {
 	encountered := sets.NewString()
 	for _, r := range resources {

diff --git a/pkg/apis/pipeline/v1beta1/taskrun_defaults_test.go b/pkg/apis/pipeline/v1beta1/taskrun_defaults_test.go
@@ -5,7 +5,7 @@ Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
 You may obtain a copy of the License at
 
-    http://www.apache.org/licenses/LICENSE-2.0
+	http://www.apache.org/licenses/LICENSE-2.0
 
 Unless required by applicable law or agreed to in writing, software
 distributed under the License is distributed on an "AS IS" BASIS,

diff --git a/pkg/client/clientset/versioned/fake/register.go b/pkg/client/clientset/versioned/fake/register.go
diff --git a/pkg/client/clientset/versioned/scheme/register.go b/pkg/client/clientset/versioned/scheme/register.go
diff --git a/pkg/client/resolution/clientset/versioned/fake/register.go b/pkg/client/resolution/clientset/versioned/fake/register.go
diff --git a/pkg/client/resolution/clientset/versioned/scheme/register.go b/pkg/client/resolution/clientset/versioned/scheme/register.go
diff --git a/pkg/client/resource/clientset/versioned/fake/register.go b/pkg/client/resource/clientset/versioned/fake/register.go
diff --git a/pkg/client/resource/clientset/versioned/scheme/register.go b/pkg/client/resource/clientset/versioned/scheme/register.go
diff --git a/pkg/controller/filter.go b/pkg/controller/filter.go
@@ -33,10 +33,10 @@ import (
 // For example, a controller impl that wants to be notified of updates to Runs
 // which reference a Task with apiVersion "example.dev/v0" and kind "Example":
 //
-//     runinformer.Get(ctx).Informer().AddEventHandler(cache.FilteringResourceEventHandler{
-//       FilterFunc: FilterRunRef("example.dev/v0", "Example"),
-//       Handler:    controller.HandleAll(impl.Enqueue),
-//     })
+//	runinformer.Get(ctx).Informer().AddEventHandler(cache.FilteringResourceEventHandler{
+//	  FilterFunc: FilterRunRef("example.dev/v0", "Example"),
+//	  Handler:    controller.HandleAll(impl.Enqueue),
+//	})
 func FilterRunRef(apiVersion, kind string) func(interface{}) bool {
 	return func(obj interface{}) bool {
 		r, ok := obj.(*v1alpha1.Run)
@@ -66,10 +66,10 @@ func FilterRunRef(apiVersion, kind string) func(interface{}) bool {
 // For example, a controller impl that wants to be notified of updates to TaskRuns that are controlled by
 // a Run which references a custom task with apiVersion "example.dev/v0" and kind "Example":
 //
-//     taskruninformer.Get(ctx).Informer().AddEventHandler(cache.FilteringResourceEventHandler{
-//       FilterFunc: FilterOwnerRunRef("example.dev/v0", "Example"),
-//       Handler:    controller.HandleAll(impl.Enqueue),
-//     })
+//	taskruninformer.Get(ctx).Informer().AddEventHandler(cache.FilteringResourceEventHandler{
+//	  FilterFunc: FilterOwnerRunRef("example.dev/v0", "Example"),
+//	  Handler:    controller.HandleAll(impl.Enqueue),
+//	})
 func FilterOwnerRunRef(runLister listersalpha.RunLister, apiVersion, kind string) func(interface{}) bool {
 	return func(obj interface{}) bool {
 		object, ok := obj.(metav1.Object)

diff --git a/pkg/internal/affinityassistant/transformer_test.go b/pkg/internal/affinityassistant/transformer_test.go
@@ -5,7 +5,7 @@ Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
 You may obtain a copy of the License at
 
-    http://www.apache.org/licenses/LICENSE-2.0
+	http://www.apache.org/licenses/LICENSE-2.0
 
 Unless required by applicable law or agreed to in writing, software
 distributed under the License is distributed on an "AS IS" BASIS,

diff --git a/pkg/internal/computeresources/compare/compare.go b/pkg/internal/computeresources/compare/compare.go
@@ -5,7 +5,7 @@ Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
 You may obtain a copy of the License at
 
-    http://www.apache.org/licenses/LICENSE-2.0
+	http://www.apache.org/licenses/LICENSE-2.0
 
 Unless required by applicable law or agreed to in writing, software
 distributed under the License is distributed on an "AS IS" BASIS,

diff --git a/pkg/internal/computeresources/limitrange/limitrange_test.go b/pkg/internal/computeresources/limitrange/limitrange_test.go
@@ -5,7 +5,7 @@ Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
 You may obtain a copy of the License at
 
-    http://www.apache.org/licenses/LICENSE-2.0
+	http://www.apache.org/licenses/LICENSE-2.0
 
 Unless required by applicable law or agreed to in writing, software
 distributed under the License is distributed on an "AS IS" BASIS,

diff --git a/pkg/internal/computeresources/transformer_test.go b/pkg/internal/computeresources/transformer_test.go
@@ -5,7 +5,7 @@ Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
 You may obtain a copy of the License at
 
-    http://www.apache.org/licenses/LICENSE-2.0
+	http://www.apache.org/licenses/LICENSE-2.0
 
 Unless required by applicable law or agreed to in writing, software
 distributed under the License is distributed on an "AS IS" BASIS,

diff --git a/pkg/reconciler/doc.go b/pkg/reconciler/doc.go
@@ -21,10 +21,12 @@ limitations under the License.
 //
 // Despite defining a Reconciler, each of the packages here are expected to
 // expose a controller constructor like:
-//    func NewController(...) *controller.Impl { ... }
+//
+//	func NewController(...) *controller.Impl { ... }
+//
 // These constructors will:
-// 1. Construct the Reconciler,
-// 2. Construct a controller.Impl with that Reconciler,
-// 3. Wire the assorted informers this Reconciler watches to call appropriate
-//   enqueue methods on the controller.
+//  1. Construct the Reconciler,
+//  2. Construct a controller.Impl with that Reconciler,
+//  3. Wire the assorted informers this Reconciler watches to call appropriate
+//     enqueue methods on the controller.
 package reconciler
diff --git a/pkg/reconciler/pipelinerun/resources/input_output_steps_test.go b/pkg/reconciler/pipelinerun/resources/input_output_steps_test.go
@@ -5,7 +5,7 @@ Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
 You may obtain a copy of the License at
 
-    http://www.apache.org/licenses/LICENSE-2.0
+	http://www.apache.org/licenses/LICENSE-2.0
 
 Unless required by applicable law or agreed to in writing, software
 distributed under the License is distributed on an "AS IS" BASIS,

diff --git a/pkg/reconciler/resolutionrequest/doc.go b/pkg/reconciler/resolutionrequest/doc.go
@@ -21,8 +21,8 @@ that global settings and constraints are enforced independent of
 the "type" of ResolutionRequest being resolved.
 
 Examples of the kinds of global settings that need to be enforced include:
-	* Ensuring that the object's Status fields are correctly initialized.
-	* Ensuring that all ResolutionRequests eventually get timed out.
-	* Ensuring that ResolutionRequests with populated Data field are marked as complete.
+  - Ensuring that the object's Status fields are correctly initialized.
+  - Ensuring that all ResolutionRequests eventually get timed out.
+  - Ensuring that ResolutionRequests with populated Data field are marked as complete.
 */
 package resolutionrequest
diff --git a/pkg/reconciler/taskrun/resources/output_resource.go b/pkg/reconciler/taskrun/resources/output_resource.go
@@ -37,8 +37,10 @@ var (
 // target directory.
 // Steps executed:
 //  1. If taskrun has owner reference as pipelinerun then all outputs are copied to parents PVC
+//
 // and also runs any custom upload steps (upload to blob store)
-//  2.  If taskrun does not have pipelinerun as owner reference then all outputs resources execute their custom
+//  2. If taskrun does not have pipelinerun as owner reference then all outputs resources execute their custom
+//
 // upload steps (like upload to blob store )
 //
 // Resource source path determined

diff --git a/pkg/reconciler/taskrun/resources/volume.go b/pkg/reconciler/taskrun/resources/volume.go
@@ -36,14 +36,14 @@ func GetPVCVolume(name string) corev1.Volume {
 // Specifically, they have the following structure as defined by
 // (pkg/apis/resource/v1alpha1/storage.ArtifactBucket).GetSecretsVolumes():
 //
-// corev1.Volume{
-//   Name: fmt.Sprintf("volume-bucket-%s", sec.SecretName),
-//   VolumeSource: corev1.VolumeSource{
-//     Secret: &corev1.SecretVolumeSource{
-//       SecretName: sec.SecretName,
-//     },
-//   },
-// }
+//	corev1.Volume{
+//	  Name: fmt.Sprintf("volume-bucket-%s", sec.SecretName),
+//	  VolumeSource: corev1.VolumeSource{
+//	    Secret: &corev1.SecretVolumeSource{
+//	      SecretName: sec.SecretName,
+//	    },
+//	  },
+//	}
 //
 // Any new volumes that don't match this structure are added regardless of whether they are already
 // present in the list of volumes.

diff --git a/pkg/remote/errors.go b/pkg/remote/errors.go
@@ -5,7 +5,7 @@ Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
 You may obtain a copy of the License at
 
-    http://www.apache.org/licenses/LICENSE-2.0
+	http://www.apache.org/licenses/LICENSE-2.0
 
 Unless required by applicable law or agreed to in writing, software
 distributed under the License is distributed on an "AS IS" BASIS,

diff --git a/pkg/termination/parse_test.go b/pkg/termination/parse_test.go
@@ -5,7 +5,7 @@ Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
 You may obtain a copy of the License at
 
-    http://www.apache.org/licenses/LICENSE-2.0
+	http://www.apache.org/licenses/LICENSE-2.0
 
 Unless required by applicable law or agreed to in writing, software
 distributed under the License is distributed on an "AS IS" BASIS,

diff --git a/pkg/termination/write_test.go b/pkg/termination/write_test.go
@@ -5,7 +5,7 @@ Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
 You may obtain a copy of the License at
 
-    http://www.apache.org/licenses/LICENSE-2.0
+	http://www.apache.org/licenses/LICENSE-2.0
 
 Unless required by applicable law or agreed to in writing, software
 distributed under the License is distributed on an "AS IS" BASIS,
-Original file line number
+Diff line change
@@ Expand Up @@
     }
     // PodTemplate holds pod specific configuration
+    //
     //nolint:revive
     type PodTemplate = Template
@@ Expand Down @@