Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update how we identify the correct pod to use for logs #843

Closed
AlanGreene opened this issue Dec 16, 2019 · 10 comments
Closed

Update how we identify the correct pod to use for logs #843

AlanGreene opened this issue Dec 16, 2019 · 10 comments
Labels
kind/misc Categorizes issue or PR as a miscellaneuous one.

Comments

@AlanGreene
Copy link
Member

See tektoncd/pipeline#1689 and associated PR for details.

TL;DR:
.status.podName may be removed in future. We should consider updating our strategy to identify the correct pod, i.e. by using labelSelector with tekton.dev/taskRun={taskRunName}.
@mnuttall mnuttall added this to the 0.6.0 milestone Feb 14, 2020
@Megan-Wright
Copy link
Member

/assign

@AlanGreene
Copy link
Member Author

fyi, no rush on this one currently as the change in pipelines was reverted due to a regression it caused for retries.

@Megan-Wright
Copy link
Member

Ok, in that case I'm going to unassign myself since there's more urgent work I'm currently doing

@Megan-Wright Megan-Wright removed their assignment Mar 4, 2020
@AlanGreene AlanGreene removed this from the 0.6.0 milestone Mar 16, 2020
@AlanGreene
Copy link
Member Author

Not currently needed, we can reopen if this changes in a future pipelines version.

@AlanGreene
Copy link
Member Author

Looks like this is being revisited

@AlanGreene AlanGreene reopened this Apr 24, 2020
@tekton-robot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Aug 14, 2020
@AlanGreene
Copy link
Member Author

/remove-lifecycle stale
/remove-lifecycle rotten

@tekton-robot tekton-robot removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Aug 14, 2020
@AlanGreene
Copy link
Member Author

Putting this one on ice for now as there are no immediate plans to remove the pod name.

@AlanGreene AlanGreene added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Dec 2, 2020
@AlanGreene
Copy link
Member Author

Closing since there's no sign of this changing anytime soon. We can reopen if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/misc Categorizes issue or PR as a miscellaneuous one.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@AlanGreene @mnuttall @tekton-robot @Megan-Wright