Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more rendering options in pipelineRun generatedName #3323

Closed
caiocampoos opened this issue Feb 20, 2024 · 4 comments
Closed

Add more rendering options in pipelineRun generatedName #3323

caiocampoos opened this issue Feb 20, 2024 · 4 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@caiocampoos
Copy link

Feature request

We want to render links and tags on the pipeline run generated name, currently only working with alphanumeric lowercase and - characters.

Use case

We want to render links and tags to organize better our workflows. Something like Circleci or more custom.

Additional context

Something like this.

Screenshot 2024-02-20 at 12 08 04

@caiocampoos caiocampoos added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 20, 2024
@AlanGreene
Copy link
Member

Hi @caiocampoos, thanks for the feature request. Can you elaborate a bit on what exactly you're trying to do?

It would be really helpful if you could provide an example of the PipelineRun YAML, identify which piece specifically doesn't currently meet your needs, and describe how you expect it to be handled.

@caiocampoos
Copy link
Author

caiocampoos commented Feb 21, 2024

@AlanGreene of course, thanks for the reply.
I am currently trying to add a link to the pull request that trigger the pipeline run, so on tekton dashboard i can easily click a link and go to github on the correct pull request. I could not quite figure it out by the dashboard documentation how to do that, the further i got was just displaying the ref and author of the pr in the pipeline generated name.

- apiVersion: tekton.dev/v1beta1
      kind: PipelineRun
      metadata:
        generateName: pr-$(tt.params.ref)-$(tt.params.author)-
      spec:
        serviceAccountName: service-account-{{ .Values.projectName }}

        pipelineRef:
          name: {{ .Values.projectName}}-pipeline
        workspaces:
          - name: shared-data

I would imagine we could have something like a displayName, that can accept more elaborate html to be rendered in the dashboard.

@AlanGreene
Copy link
Member

There's currently no displayName support in the PipelineRun resource.

There are both displayName and description fields on Task and Pipeline resources, but not on PipelineRun.

See:

Something like a displayName field would need to be supported by the underlying CRD (PipelineRun in this case) before we could process and display it in the Dashboard.

It might make sense to propose this as an enhancement to Tekton Pipelines. You can find details of the process for proposing new features at https://github.com/tektoncd/community/tree/main/process#proposing-features

It's also worth noting that the Dashboard does currently display information about the EventListener and Trigger if the run was created by Tekton Triggers.

@AlanGreene
Copy link
Member

Closing as there's currently nothing for the Dashboard to do here. Feel free to propose a TEP as described above to add a display name or similar field to the PipelineRun CRD.

@AlanGreene AlanGreene closed this as not planned Won't fix, can't repro, duplicate, stale Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants