TEP-0090: Matrix - Status #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
kind/tep
tekton-robot
added
the
size/L
|
cc @abayer @dibyom @lbernick @pritidesai please take a look |
dibyom
approved these changes
Jun 10, 2022
tekton-robot
added
the
approved
tekton-robot
added
size/M
lbernick
approved these changes
Jun 10, 2022
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abayer, dibyom, lbernick The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
API WG 6/13 |
[TEP-0090: Matrix][tep-0090] proposed executing a `PipelineTask` in parallel `TaskRuns` and `Runs` with substitutions from combinations of `Parameters` in a `Matrix`. In this change, we describe how the status of a `PipelineRun` with a matrixed `PipelineTask` would be in full and minimal modes. Previously, we had included `matrixId` to the `PipelineRun` status so that it can help with identifying `Results` from fanned out `TaskRuns` or `Runs`. However, we ended up descoping that problem so that it can be addressed when TEP-0075 and TEP-0076 are implemented. See [`Results` from fanned-out `PipelineTasks`][results] for details. In this change, we remove the `matrixId` in `PipelineRun` status so that the problem can be addressed completely later. [tep-0090]: https://github.com/tektoncd/community/blob/main/teps/0090-matrix.md [results]: https://github.com/tektoncd/community/blob/main/teps/0090-matrix.md#results-from-fanned-out-pipelinetasks
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TEP-0090: Matrix proposed executing a
PipelineTaskinparallel
TaskRunsandRunswith substitutions from combinationsof
Parametersin aMatrix.In this change, we describe how the status of a
PipelineRunwitha matrixed
PipelineTaskwould be in full and minimal modes.Previously, we had included
matrixIdto thePipelineRunstatusso that it can help with identifying
Resultsfrom fanned outTaskRunsorRuns. However, we ended up descoping that problemso that it can be addressed when TEP-0075 and TEP-0076 are implemented.
See
Resultsfrom fanned-outPipelineTasksfor details.In this change, we remove the
matrixIdinPipelineRunstatus sothat the problem can be addressed completely later.
/kind tep