Set status to succeeded when the reason is Completed

[chmouel]

When a task is skipped in a when expression, the reason becomes Completed, which shows as succeeded (Completed). This can be confusing compared to other tasks that are succeeded but not completed.

Users would not be able to tell the difference when they essentially mean the same thing.

Therefore, set the status to succeeded when the reason is Completed without displaying the reason.

This was how the pipelinerun would show when it's completed:

which makes it confusing since we don't know what happen, why some pr are completed and not completed but successfull? this pr fix this since they are successfull we don't need to know more than that.

This is how it looks like now:

Further improvement perhaps would be to add support for when expression in tkn pr show

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Run the code checkers with make check
• Regenerate the manpages, docs and go formatting with make generated
• Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

when a pipelinerun is succeeded and have a reason of completed (due of a when condition) we don't show the completed reason to avoid confusion

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vdemeester]

/lgtm