Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-commit on cli repo is broken #2303

Closed
chmouel opened this issue May 2, 2024 · 0 comments · Fixed by #2325
Closed

pre-commit on cli repo is broken #2303

chmouel opened this issue May 2, 2024 · 0 comments · Fixed by #2325
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.

Comments

@chmouel
Copy link
Member

chmouel commented May 2, 2024

% pre-commit run -a
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
check for added large files..............................................Passed
check toml...........................................(no files to check)Skipped
check that scripts with shebangs are executable..........................Passed
check json...........................................(no files to check)Skipped
check vcs permalinks.....................................................Failed
- hook id: check-vcs-permalinks
- exit code: 1

RELEASE_PROCESS.md:9:- You need to have [these tools](https://github.com/tektoncd/cli/blob/main/tekton/release.sh#L13y) installed locally.
RELEASE_PROCESS.md:58:  * Make sure you get the proper `sha256sum`. You need to download the `Source Code (tar.gz)` from this [link](https://github.com/Homebrew/homebrew-core/blob/master/Formula/tektoncd-cli.rb#L4), but replace the version number with the version number you have released. After downloading, run the command below on the downloaded file (once again you will need to replace the version shown below with the released version):

Non-permanent github link detected.
On any page on github press [y] to load a permalink.
choco/README.md:33:* Edit the version property in [`tektoncd-cli.nuspec`](https://github.com/tektoncd/cli/blob/main/choco/tektoncd-cli.nuspec#L5) to the latest available version of `tkn`. 
choco/README.md:34:* Change the [version in the download url for the Windows `tkn` zip](https://github.com/tektoncd/cli/blob/main/choco/tools/chocolateyinstall.ps1#L4) to the latest available version of `tkn`. 
choco/README.md:35:* Update the [checksum for the package](https://github.com/tektoncd/cli/blob/main/choco/tools/chocolateyinstall.ps1#L11) by getting the sha256 of the zip file. Example: `Get-FileHash '.\tkn_0.36.0_Windows_x86_64.zip'`. The zip can be downloaded using the release download url from GitHub; just remember to change the version numbers in the url: https://github.com/tektoncd/cli/releases/download/v0.36.0/tkn_0.36.0_Windows_x86_64.zip.

Non-permanent github link detected.
On any page on github press [y] to load a permalink.

detect private key.......................................................Passed
Lint GO..................................................................Passed
Unit testing.............................................................Passed
Lint YAML................................................................Passed
@chmouel chmouel added kind/bug Categorizes issue or PR as related to a bug. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels May 2, 2024
@chmouel chmouel self-assigned this May 2, 2024
chmouel added a commit to chmouel/tektoncd-cli that referenced this issue May 2, 2024
this will fix the pre-commit run

Fixes tektoncd#2303

Signed-off-by: Chmouel Boudjnah <[email protected]>
piyush-garg added a commit to piyush-garg/cli that referenced this issue May 21, 2024
This will update links in doc to relative path
instead of URL to fix pre-commit error. Also
update the homebrew steps.

Fix tektoncd#2303
piyush-garg added a commit to piyush-garg/cli that referenced this issue May 21, 2024
This will update links in doc to relative path
instead of URL to fix pre-commit error. Also
update the homebrew steps.

Fix tektoncd#2303
tekton-robot pushed a commit that referenced this issue May 22, 2024
This will update links in doc to relative path
instead of URL to fix pre-commit error. Also
update the homebrew steps.

Fix #2303
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
1 participant