-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prometheus gate #440
Prometheus gate #440
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- It would be nice if you could add the task with all the files in the task directory
./task/ 👈 the kind of the resource
/prometheus-gate 👈 definition file must have same name
/0.1
/README.md 👈 [optional] since there can be a fallback
/prometheus-gate.yaml 👈 the file name must be resource name
/samples
/gate.yaml
/nginx.yaml
Please see : #389
This could use another review, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also have something in the README or in samples as how to use this task 🙂
@vinamra28 I added a better samples section and readme 👍 |
The CI error seems legit and due of some yaml linting issue.. |
@vinamra28 thanks, CI is passing now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just last one suggestion could you please squash all your commits 😅 otherwise
/lgtm
Looking good but the squashing please thanks |
fce4656
to
4bf86c9
Compare
thank you for the PR 👍 |
c9932d3
to
28bd912
Compare
Re-squashed and ready for re-review |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/meow
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
This adds a new Task
prometheus-gate
, aimed at for keeping Tasks and Pipelines gated (eg intentionally blocked) until a certain criteria is met. This Task uses Prometheus range query to obtain range data for the provided query, and asserts all values returned by prometheus are at/above/below target for N times, or fails the pipeline task. The source for the simple gate is here.Is this a good fit for the catalog? I intend to follow with creating a custom task from this once I have learned more. More details in the linked issue.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
File path follows
<kind>/<name>/<version>/name.yaml
Has
README.md
at<kind>/<name>/<version>/README.md
Has mandatory
metadata.labels
-app.kubernetes.io/version
the same as the<version>
of the resourceHas mandatory
metadata.annotations
tekton.dev/pipelines.minVersion
mandatory
spec.description
follows the conventionSee the contribution guide
for more details.