-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modifies directory names based on the proposal #416
Conversation
- sample --> samples - example --> samples - test --> tests Signed-off-by: Puneet Punamiya <[email protected]>
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/lgtm |
/lgtm |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may have to change the hyperlinks in few tasks README.md
as well because after refactoring to samples
all hyperlinks where examples
is used will break.
for eg.
The following pipelines demonstrate usage of the git-clone Task:
- [Cloning a branch](./examples/git-clone-checking-out-a-branch.yaml)
- [Checking out a specific git commit](./examples/git-clone-checking-out-a-commit.yaml)
- [Checking out a git tag and using the "commit" Task Result](./examples/using-git-clone-task-result.yaml)
May be we can address all this together in a seperate PR. Otherwise
/lgtm
@divyansh42 made a good point about updating the links so im gonna add a hold but feel free to remove depending on whether you want to fix that in this PR or another one: /hold Thanks for taking care of this! /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bobcatfish, sthaha, vinamra28 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@bobcatfish will it be fine if I would add a separate follow-up pr to the readme change to make the review a little easier |
sure! /hold cancel |
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
File path follows
<kind>/<name>/<version>/name.yaml
Has
README.md
at<kind>/<name>/<version>/README.md
Has mandatory
metadata.labels
-app.kubernetes.io/version
the same as the<version>
of the resourceHas mandatory
metadata.annotations
tekton.dev/pipelines.minVersion
mandatory
spec.description
follows the conventionSee the contribution guide
for more details.