Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifies directory names based on the proposal #416

Merged
merged 1 commit into from
Jul 14, 2020
Merged

Modifies directory names based on the proposal #416

merged 1 commit into from
Jul 14, 2020

Conversation

PuneetPunamiya
Copy link
Member

Changes

  • sample --> samples
  • example --> samples
  • test --> tests

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Yaml file complies with yamllint rules.
  • Complies with Catalog Orgainization TEP, see example. Note An issue has been filed to automate this validation
    • File path follows <kind>/<name>/<version>/name.yaml

    • Has README.md at <kind>/<name>/<version>/README.md

    • Has mandatory metadata.labels - app.kubernetes.io/version the same as the <version> of the resource

    • Has mandatory metadata.annotations tekton.dev/pipelines.minVersion

    • mandatory spec.description follows the convention

        ```
      
        spec:
          description: >-
            one line summary of the resource
      
            Paragraph(s) to describe the resource.
        ```
      

See the contribution guide
for more details.


  - sample --> samples
  - example --> samples
  - test --> tests

Signed-off-by: Puneet Punamiya <[email protected]>
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 14, 2020
@sthaha
Copy link
Member

sthaha commented Jul 14, 2020

/lgtm
/approve

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2020
Copy link
Member

@vinamra28 vinamra28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@nikhil-thomas
Copy link
Member

/lgtm

@piyush-garg
Copy link
Contributor

/lgtm

@fhopfensperger
Copy link
Member

/lgtm

Copy link
Member

@divyansh42 divyansh42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may have to change the hyperlinks in few tasks README.md as well because after refactoring to samples all hyperlinks where examples is used will break.

for eg.

The following pipelines demonstrate usage of the git-clone Task:

- [Cloning a branch](./examples/git-clone-checking-out-a-branch.yaml)
- [Checking out a specific git commit](./examples/git-clone-checking-out-a-commit.yaml)
- [Checking out a git tag and using the "commit" Task Result](./examples/using-git-clone-task-result.yaml)

May be we can address all this together in a seperate PR. Otherwise
/lgtm

@bobcatfish
Copy link
Contributor

@divyansh42 made a good point about updating the links so im gonna add a hold but feel free to remove depending on whether you want to fix that in this PR or another one:

/hold

Thanks for taking care of this!

/approve

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 14, 2020
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bobcatfish, sthaha, vinamra28

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 14, 2020
@PuneetPunamiya
Copy link
Member Author

@bobcatfish will it be fine if I would add a separate follow-up pr to the readme change to make the review a little easier

@bobcatfish
Copy link
Contributor

sure!

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 14, 2020
@tekton-robot tekton-robot merged commit 40393cd into tektoncd:master Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants