-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Task to Trigger Jenkins Build using Tekton #391
Add Task to Trigger Jenkins Build using Tekton #391
Conversation
8f6f3e7
to
6e7b6d1
Compare
neat!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like it could be a good candidate for a Custom Task, that invokes a remote Jenkins installation and polls the status until it completes, and reports success/failure.
If you're interested I'd love to help work on something like this as an example that could help hone the Custom Tasks proposal, and provide this as a higher-level feature of Tekton.
(This shouldn't block this specific PR, but it jumped out to me as something we could support at a higher level)
@imjasonh Thanks for the review. Sure, will love to do that and take this task to the higher level. 😄 |
23210d0
to
b6c1710
Compare
hi @imjasonh, what can I do to get this PR merged and start with the Custom Task proposal or are we going to include that(Custom Task Proposal) in the current PR. Also please guide me as how to get started with that 😄 |
Hey, sorry for the delay. I don't think we should drop this PR in favor of a Custom Tasks approach, so submitting it as a regular Task like you're doing here should be fine. The only problem is I actually have no familiarity with Jenkins and so probably can't really review it very well. Is there someone else you think could review it that might know more about Jenkins? |
b6c1710
to
f717163
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/lgtm |
The following task can be used to trigger an existing Jenkins pipeline from Tekton using the CURL request by providing the required parameters. Signed-off-by: vinamra28 <[email protected]>
f717163
to
71477b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@imjasonh I just went through the manisfests and tried it out on Jenkins with @vinamra28. It looks good to me. It is definitely useful to have this to allow tekton users to trigger their jenkins jobs. |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/meow
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
The following task can be used to trigger an existing Jenkins pipeline from Tekton using the CURL request by providing the required parameters.
Signed-off-by: vinamra28 [email protected]
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
File path follows
<kind>/<name>/<version>/name.yaml
Has
README.md
at<kind>/<name>/<version>/README.md
Has mandatory
metadata.labels
-app.kubernetes.io/version
the same as the<version>
of the resourceHas mandatory
metadata.annotations
tekton.dev/pipelines.minVersion
mandatory
spec.description
follows the conventionSee the contribution guide
for more details.