Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Task to Trigger Jenkins Build using Tekton #391

Merged
merged 1 commit into from
Jul 29, 2020

Conversation

vinamra28
Copy link
Member

@vinamra28 vinamra28 commented Jun 25, 2020

Changes

The following task can be used to trigger an existing Jenkins pipeline from Tekton using the CURL request by providing the required parameters.

Signed-off-by: vinamra28 [email protected]

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Yaml file complies with yamllint rules.
  • Complies with Catalog Orgainization TEP, see example. Note An issue has been filed to automate this validation
    • File path follows <kind>/<name>/<version>/name.yaml

    • Has README.md at <kind>/<name>/<version>/README.md

    • Has mandatory metadata.labels - app.kubernetes.io/version the same as the <version> of the resource

    • Has mandatory metadata.annotations tekton.dev/pipelines.minVersion

    • mandatory spec.description follows the convention

        ```
      
        spec:
          description: >-
            one line summary of the resource
      
            Paragraph(s) to describe the resource.
        ```
      

See the contribution guide
for more details.


@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 25, 2020
@bobcatfish
Copy link
Contributor

neat!!

@vinamra28 vinamra28 changed the title Add Task to Trigger Jenkins Pipeline using Tekton Add Task to Trigger Jenkins Build using Tekton Jul 6, 2020
Copy link
Member

@imjasonh imjasonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like it could be a good candidate for a Custom Task, that invokes a remote Jenkins installation and polls the status until it completes, and reports success/failure.

If you're interested I'd love to help work on something like this as an example that could help hone the Custom Tasks proposal, and provide this as a higher-level feature of Tekton.

(This shouldn't block this specific PR, but it jumped out to me as something we could support at a higher level)

@vinamra28
Copy link
Member Author

@imjasonh Thanks for the review. Sure, will love to do that and take this task to the higher level. 😄

@vinamra28 vinamra28 requested a review from imjasonh July 10, 2020 15:23
@vinamra28 vinamra28 force-pushed the vinamra28/triggers-jenkins branch 3 times, most recently from 23210d0 to b6c1710 Compare July 14, 2020 07:35
@vinamra28
Copy link
Member Author

hi @imjasonh, what can I do to get this PR merged and start with the Custom Task proposal or are we going to include that(Custom Task Proposal) in the current PR. Also please guide me as how to get started with that 😄

@imjasonh
Copy link
Member

hi @imjasonh, what can I do to get this PR merged and start with the Custom Task proposal or are we going to include that(Custom Task Proposal) in the current PR. Also please guide me as how to get started with that 😄

Hey, sorry for the delay. I don't think we should drop this PR in favor of a Custom Tasks approach, so submitting it as a regular Task like you're doing here should be fine. The only problem is I actually have no familiarity with Jenkins and so probably can't really review it very well. Is there someone else you think could review it that might know more about Jenkins?

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2020
@waveywaves
Copy link
Member

/lgtm

The following task can be used to trigger an existing Jenkins pipeline from Tekton using the CURL request by providing the required parameters.

Signed-off-by: vinamra28 <[email protected]>
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2020
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2020
@waveywaves
Copy link
Member

@imjasonh I just went through the manisfests and tried it out on Jenkins with @vinamra28. It looks good to me. It is definitely useful to have this to allow tekton users to trigger their jenkins jobs.

@waveywaves
Copy link
Member

/lgtm

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/meow

@tekton-robot
Copy link

@vdemeester: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2020
@tekton-robot tekton-robot merged commit f1317ea into tektoncd:master Jul 29, 2020
@vinamra28 vinamra28 deleted the vinamra28/triggers-jenkins branch July 29, 2020 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants