Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version of tekton catalog publish with labels #1304

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

afrittoli
Copy link
Member

Changes

Add a new version of the catalog publish step action. This new version API is backwards compatible, as it adds one new optional parameter only, TKN_ARGS.

The new version includes the following changes:

  • latest version of tkn image set by default
  • sets two OCI labels org.opencontainers.image.description and org.opencontainers.image.version for each resource
  • accepts TKN_ARGS which is passed to all resources and can be used to set additional OCI labels as well as other settings

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Follows the authoring recommendations
  • Includes docs (if user facing)
  • Includes tests (for new tasks or changed functionality)
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Commit messages follow commit message best practices
  • Has a kind label. You can add one by adding a comment on this PR that
    contains /kind <type>. Valid types are bug, cleanup, design, documentation,
    feature, flake, misc, question, tep
  • Complies with Catalog Organization TEP, see example. Note An issue has been filed to automate this validation
    • File path follows <kind>/<name>/<version>/name.yaml

    • Has README.md at <kind>/<name>/<version>/README.md

    • Has mandatory metadata.labels - app.kubernetes.io/version the same as the <version> of the resource

    • Has mandatory metadata.annotations tekton.dev/pipelines.minVersion

    • mandatory spec.description follows the convention

        ```
      
        spec:
          description: >-
            one line summary of the resource
      
            Paragraph(s) to describe the resource.
        ```
      

See the contribution guide for more details.

/kind feature

Add a new version of the catalog publish step action. This
new version API is backwards compatible, as it adds one new
optional parameter only, `TKN_ARGS`.

The new version includes the following changes:
- latest version of tkn image set by default
- sets two OCI labels org.opencontainers.image.description
  and org.opencontainers.image.version for each resource
- accepts TKN_ARGS which is passed to all resources and
  can be used to set additional OCI labels as well as other
  settings

Signed-off-by: Andrea Frittoli <[email protected]>
@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 1, 2024
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 1, 2024
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2024
Copy link
Member

@vinamra28 vinamra28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester, vinamra28

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [vdemeester,vinamra28]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2024
@tekton-robot tekton-robot merged commit ead4761 into tektoncd:main Oct 1, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants