Corrected mountpath in aws-cli task

[aokugel]

Changes

Fixes the incorrect mountpath referenced in issue #1210

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Follows the authoring recommendations
• Includes docs (if user facing)
• Includes tests (for new tasks or changed functionality)
  • See the end-to-end testing documentation for guidance and CI details.
• Meets the Tekton contributor standards (including functionality, content, code)
• Commit messages follow commit message best practices
• Has a kind label. You can add one by adding a comment on this PR that
  contains /kind <type>. Valid types are bug, cleanup, design, documentation,
  feature, flake, misc, question, tep
• Complies with Catalog Organization TEP, see example. Note An issue has been filed to automate this validation

  • File path follows <kind>/<name>/<version>/name.yaml

  • Has README.md at <kind>/<name>/<version>/README.md

  • Has mandatory metadata.labels - app.kubernetes.io/version the same as the <version> of the resource

  • Has mandatory metadata.annotations tekton.dev/pipelines.minVersion

  • mandatory spec.description follows the convention

      ```
    
      spec:
        description: >-
          one line summary of the resource
    
          Paragraph(s) to describe the resource.
      ```
    

See the contribution guide for more details.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: aokugel / name: Anthony Kugel (e97a437)

[tekton-robot]

Hi @aokugel. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tekton-robot]

Catlin Output

FILE: task/aws-cli/0.2/aws-cli.yaml

Catlin script lint Output

ERROR: /usr/bin/shellcheck, [-s sh] failed:

In aws-cli-awscli line 2:
$(params.SCRIPT)
^--------------^ SC2091 (warning): Remove surrounding $() to avoid executing output (or use eval if intentional).

For more information:
  https://www.shellcheck.net/wiki/SC2091 -- Remove surrounding $() to avoid e...

[vinamra28]

hi @aokugel, changing this to /root will lead to issues for those who are running these tasks as non-root

[vinamra28]

is there any workaround apart from changing the mountPath to /root ?

[aokugel]

I believe it may be possible to change the directory that the aws-cli image is looking for the config/credentials using an environment variable:

aws/aws-cli#5120 (comment)

I can look into this.

[aokugel]

by utilizing a stepTemplate we can set the HOME environment variable to /tekton/home, which allows the aws config/credentials to work as expected. Would this be a satisfactory solution?

[vinamra28]

yes @aokugel, this can be done

[tekton-robot]

Catlin Output

FILE: task/aws-cli/0.2/aws-cli.yaml

Catlin script lint Output

ERROR: /usr/bin/shellcheck, [-s sh] failed:

In aws-cli-awscli line 2:
$(params.SCRIPT)
^--------------^ SC2091 (warning): Remove surrounding $() to avoid executing output (or use eval if intentional).

For more information:
  https://www.shellcheck.net/wiki/SC2091 -- Remove surrounding $() to avoid e...

[vinamra28]

/ok-to-test

[aokugel]

/retest

[vinamra28]

/lgtm

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vinamra28

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vinamra28]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment