Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RHACS image scan version to 0.1/0.2. #1271

Closed

Conversation

dhaus67
Copy link
Contributor

@dhaus67 dhaus67 commented Jun 7, 2024

Changes

As discussed within Slack, updating the version of the task to be according to guidelines.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Follows the authoring recommendations
  • Includes docs (if user facing)
  • Includes tests (for new tasks or changed functionality)
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Commit messages follow commit message best practices
  • Has a kind label. You can add one by adding a comment on this PR that
    contains /kind <type>. Valid types are bug, cleanup, design, documentation,
    feature, flake, misc, question, tep
  • Complies with Catalog Organization TEP, see example. Note An issue has been filed to automate this validation
    • File path follows <kind>/<name>/<version>/name.yaml

    • Has README.md at <kind>/<name>/<version>/README.md

    • Has mandatory metadata.labels - app.kubernetes.io/version the same as the <version> of the resource

    • Has mandatory metadata.annotations tekton.dev/pipelines.minVersion

    • mandatory spec.description follows the convention

        ```
      
        spec:
          description: >-
            one line summary of the resource
      
            Paragraph(s) to describe the resource.
        ```
      

See the contribution guide for more details.

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign bobcatfish after the PR has been reviewed.
You can assign the PR to them by writing /assign @bobcatfish in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 7, 2024
@dhaus67
Copy link
Contributor Author

dhaus67 commented Jun 7, 2024

/kind feature

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 7, 2024
@tekton-robot
Copy link

Catlin Output
FILE: task/rhacs-image-scan/0.1/rhacs-image-scan.yaml
WARN : Step "rox-image-scan" uses image "$(params.rox_image)" that contains variables; skipping validation
FILE: task/rhacs-image-scan/0.2/rhacs-image-scan.yaml

@vdemeester
Copy link
Member

Given that it is already indexed by artifactub, I wonder if that's worth changing now (as artifacthub might keep showing the "non-reachable" 4.0.0 release)

2024-06-10-121527

@dhaus67
Copy link
Contributor Author

dhaus67 commented Jun 11, 2024

@vdemeester The main point why we wanted to make the version change was to be able to browse those tasks while using e.g. the OpenShift pipelines operator. Currently the tasks do not show up, and also while browsing https://hub.tekton.dev they also do not show up.

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 17, 2024
@tekton-robot
Copy link

@dhaus67: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dhaus67
Copy link
Contributor Author

dhaus67 commented Jun 25, 2024

Not required anymore, as the Hub has been updated to display v1 Tasks.

@dhaus67 dhaus67 closed this Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants