task: Add generic RHACS task #1267

rhybrillou · 2024-05-29T13:10:06Z

Changes

Add a generic task for custom interactions with Red Hat Advanced Cluster Security.

This allows users to perform any action with the roxctl cli.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Follows the authoring recommendations
Includes docs (if user facing)
Includes tests (for new tasks or changed functionality)
- See the end-to-end testing documentation for guidance and CI details.
Meets the Tekton contributor standards (including functionality, content, code)
Commit messages follow commit message best practices
Has a kind label. You can add one by adding a comment on this PR that
contains /kind <type>. Valid types are bug, cleanup, design, documentation,
feature, flake, misc, question, tep
Complies with Catalog Organization TEP, see example. Note An issue has been filed to automate this validation
- File path follows <kind>/<name>/<version>/name.yaml
- Has README.md at <kind>/<name>/<version>/README.md
- Has mandatory metadata.labels - app.kubernetes.io/version the same as the <version> of the resource
- Has mandatory metadata.annotations tekton.dev/pipelines.minVersion
- mandatory spec.description follows the convention
```
  ```
  
    spec:
      description: >-
        one line summary of the resource
  
        Paragraph(s) to describe the resource.
  ```
```

See the contribution guide for more details.

tekton-robot · 2024-05-29T13:10:08Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

rhybrillou · 2024-05-29T13:10:34Z

/kind feature

vinamra28 · 2024-06-01T04:51:01Z

/test pull-catalog-catlin-lint

tekton-robot · 2024-06-01T04:51:04Z

@vinamra28: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-tekton-catalog-build-tests
/test pull-tekton-catalog-integration-tests
/test pull-tekton-catalog-unit-tests

Use /test all to run all jobs.

In response to this:

/test pull-catalog-catlin-lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vinamra28

couple of nitpicks, rest looks good

vinamra28 · 2024-06-01T07:41:12Z

task/rhacs-generic/0.1/samples/pipelinerun.yaml

@@ -0,0 +1,28 @@
+---
+apiVersion: tekton.dev/v1beta1


Suggested change

apiVersion: tekton.dev/v1beta1

apiVersion: tekton.dev/v1

vinamra28 · 2024-06-01T07:41:27Z

task/rhacs-generic/0.1/samples/pipeline.yaml

@@ -0,0 +1,185 @@
+---
+apiVersion: tekton.dev/v1beta1


Suggested change

apiVersion: tekton.dev/v1beta1

apiVersion: tekton.dev/v1

rhybrillou · 2024-06-03T09:30:30Z

/retest

vdemeester

/lgtm

tekton-robot · 2024-06-03T15:09:03Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester, vinamra28

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [vdemeester,vinamra28]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

rhybrillou · 2024-06-04T07:14:32Z

/test pull-catalog-catlin-lint

tekton-robot · 2024-06-04T07:14:34Z

@rhybrillou: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-tekton-catalog-build-tests
/test pull-tekton-catalog-integration-tests
/test pull-tekton-catalog-unit-tests

Use /test all to run all jobs.

In response to this:

/test pull-catalog-catlin-lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vdemeester · 2024-06-04T09:50:29Z

/lgtm

rhybrillou · 2024-06-04T11:10:53Z

/test all

vdemeester · 2024-06-04T11:47:46Z

/test pull-catalog-catlin-lint

tekton-robot · 2024-06-04T11:47:49Z

@vdemeester: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-tekton-catalog-build-tests
/test pull-tekton-catalog-integration-tests
/test pull-tekton-catalog-unit-tests

Use /test all to run all jobs.

In response to this:

/test pull-catalog-catlin-lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vdemeester · 2024-06-04T11:49:58Z


[post-comment : post-comment] Sending this data to GitHub: 
[post-comment : post-comment] {'body': ''}
[post-comment : post-comment] Error: 422
[post-comment : post-comment] b'{"message":"Validation Failed","errors":[{"resource":"IssueComment","code":"unprocessable","field":"data","message":"Body cannot be blank"}],"documentation_url":"https://docs.github.com/rest/issues/comments#create-an-issue-comment"}'

Hum.. 🤔

rhybrillou · 2024-06-04T12:17:35Z

/test pull-tekton-catalog-integration-tests

rhybrillou · 2024-06-04T13:23:31Z

/test pull-tekton-catalog-integration-tests

vdemeester · 2024-06-04T14:11:30Z

 FAILED: redhat-dependency-analytics/0-2 task has failed to comeback properly

It might be a legit failure isn't it ?

rhybrillou · 2024-06-04T15:26:04Z

 FAILED: redhat-dependency-analytics/0-2 task has failed to comeback properly 
It might be a legit failure isn't it ?

That is correct, but I fear the dependency analytics task is out of my realm.
The redhat-dependency-analytics/0.2 task also failed in #1255 and #1257

vdemeester · 2024-06-04T19:10:06Z

It might be a legit failure isn't it ?

That is correct, but I fear the dependency analytics task is out of my realm. The redhat-dependency-analytics/0.2 task also failed in #1255 and #1257

But it passed at some point ?

vdemeester · 2024-06-04T19:10:43Z

ah yeah it did there..

afrittoli · 2024-06-05T14:01:04Z

/test pull-catalog-catlin-lint

tekton-robot · 2024-06-05T14:01:08Z

@afrittoli: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-tekton-catalog-build-tests
/test pull-tekton-catalog-integration-tests
/test pull-tekton-catalog-unit-tests

Use /test all to run all jobs.

In response to this:

/test pull-catalog-catlin-lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

afrittoli · 2024-06-05T14:27:56Z

/test pull-catalog-catlin-lint

tekton-robot · 2024-06-05T14:27:58Z

@afrittoli: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-tekton-catalog-build-tests
/test pull-tekton-catalog-integration-tests
/test pull-tekton-catalog-unit-tests

Use /test all to run all jobs.

In response to this:

/test pull-catalog-catlin-lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

afrittoli · 2024-06-06T08:50:00Z

/test pull-catalog-catlin-lint

tekton-robot · 2024-06-06T08:50:03Z

@afrittoli: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-tekton-catalog-build-tests
/test pull-tekton-catalog-integration-tests
/test pull-tekton-catalog-unit-tests

Use /test all to run all jobs.

In response to this:

/test pull-catalog-catlin-lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 29, 2024

tekton-robot requested review from bobcatfish and vinamra28 May 29, 2024 13:10

tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 29, 2024

tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label May 29, 2024

rhybrillou marked this pull request as ready for review May 29, 2024 13:11

tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 29, 2024

tekton-robot requested a review from vdemeester May 29, 2024 13:11

rhybrillou force-pushed the rhacs-generic-task branch from 0c79f80 to 669c10b Compare May 31, 2024 08:03

vinamra28 approved these changes Jun 1, 2024

View reviewed changes

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2024

rhybrillou force-pushed the rhacs-generic-task branch from 669c10b to 34ded7a Compare June 3, 2024 08:29

vdemeester approved these changes Jun 3, 2024

View reviewed changes

tekton-robot assigned vdemeester Jun 3, 2024

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2024

tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 4, 2024

task: Add generic RHACS task

8cb31f5

rhybrillou force-pushed the rhacs-generic-task branch from 44c5a2e to 8cb31f5 Compare June 4, 2024 08:29

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 4, 2024

tekton-robot merged commit edf9ec0 into tektoncd:main Jun 6, 2024
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

task: Add generic RHACS task #1267

task: Add generic RHACS task #1267

rhybrillou commented May 29, 2024 •

edited

Loading

tekton-robot commented May 29, 2024

rhybrillou commented May 29, 2024

vinamra28 commented Jun 1, 2024

tekton-robot commented Jun 1, 2024

vinamra28 left a comment

vinamra28 Jun 1, 2024

vinamra28 Jun 1, 2024

rhybrillou commented Jun 3, 2024

vdemeester left a comment

tekton-robot commented Jun 3, 2024

rhybrillou commented Jun 4, 2024

tekton-robot commented Jun 4, 2024

vdemeester commented Jun 4, 2024

rhybrillou commented Jun 4, 2024

vdemeester commented Jun 4, 2024

tekton-robot commented Jun 4, 2024

vdemeester commented Jun 4, 2024

rhybrillou commented Jun 4, 2024

rhybrillou commented Jun 4, 2024

vdemeester commented Jun 4, 2024

rhybrillou commented Jun 4, 2024

vdemeester commented Jun 4, 2024

vdemeester commented Jun 4, 2024

afrittoli commented Jun 5, 2024

tekton-robot commented Jun 5, 2024

afrittoli commented Jun 5, 2024

tekton-robot commented Jun 5, 2024

afrittoli commented Jun 6, 2024

tekton-robot commented Jun 6, 2024

task: Add generic RHACS task #1267

task: Add generic RHACS task #1267

Conversation

rhybrillou commented May 29, 2024 • edited Loading

Changes

Submitter Checklist

tekton-robot commented May 29, 2024

rhybrillou commented May 29, 2024

vinamra28 commented Jun 1, 2024

tekton-robot commented Jun 1, 2024

vinamra28 left a comment

Choose a reason for hiding this comment

vinamra28 Jun 1, 2024

Choose a reason for hiding this comment

vinamra28 Jun 1, 2024

Choose a reason for hiding this comment

rhybrillou commented Jun 3, 2024

vdemeester left a comment

Choose a reason for hiding this comment

tekton-robot commented Jun 3, 2024

rhybrillou commented Jun 4, 2024

tekton-robot commented Jun 4, 2024

vdemeester commented Jun 4, 2024

rhybrillou commented Jun 4, 2024

vdemeester commented Jun 4, 2024

tekton-robot commented Jun 4, 2024

vdemeester commented Jun 4, 2024

rhybrillou commented Jun 4, 2024

rhybrillou commented Jun 4, 2024

vdemeester commented Jun 4, 2024

rhybrillou commented Jun 4, 2024

vdemeester commented Jun 4, 2024

vdemeester commented Jun 4, 2024

afrittoli commented Jun 5, 2024

tekton-robot commented Jun 5, 2024

afrittoli commented Jun 5, 2024

tekton-robot commented Jun 5, 2024

afrittoli commented Jun 6, 2024

tekton-robot commented Jun 6, 2024

rhybrillou commented May 29, 2024 •

edited

Loading