-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Selecting HI_RES (OAUTH) still plays HI_RES_LOSSLESS #168
Comments
Hires lossless playback should not be possible if oauth is used. I believe this is related to the bug I talked about in the other issue. You can check what is_pkce is set to in your session json file. Try to delete your oauth session and sign in again and see if it helps. |
I know. That's why I opened the ticket.
Again?.... :-( Can't I just edit the json and put |
I have deleted oauth session and signed in again. Now the track is correctly reported as HI-RES/MQA, but in the session json there is always: |
Yep, I believe I have found the cause of this bug. A fix will be added in the next release of mopidy-tidal / tidalapi. |
@tehkillerbee If you don't have planned to publish the new release soon, can I have the patch to apply locally? |
This is already fixed on the latest master. You could always install that until the next release of tidalapi/ mopidy-tidal is ready. Otherwise I'll try to get the next release ready ASAP |
Ah, ok. Does it extends to tidalapi too? |
The issue is caused by tidalapi but probably the best idea to update both mopidy-tidal and tidalapi. |
Thanks! |
I am afraid it is still there... Should I have (again) to delete the session json file? |
I have deleted the session file and now it looks OK. I will report any future issue. |
I have set HI_RES and OAUTH, as confirmed by the log:
but it still plays HI_RES_LOSSLESS/FLAC for tracks that also have HI_RES/MQA available:
The track uri
tidal:track:15796:77661290:77661291
has MQA capability, but it plays HI_RES_LOSSLESS/FLAC:Shouldn't
TidalPlaybackProvider
take care of this?The text was updated successfully, but these errors were encountered: