Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] default pdf filter does not work #84

Closed
JareBear124 opened this issue Nov 23, 2022 · 13 comments · May be fixed by #109
Closed

[BUG] default pdf filter does not work #84

JareBear124 opened this issue Nov 23, 2022 · 13 comments · May be fixed by #109
Assignees
@tefkah
Labels
bug Something isn't working

Comments

@JareBear124
Copy link

The default PDF filter is not working correctly. When setting the default value to matching background or default it only ever starts the pdfs without a filter. The filter has to be manually changed every time I open a different pdf. The Zotero dark theme functions correctly, and the pdf filter button does give the correct icon. But the pdf filter itself is not correct by default.

Steps to reproduce the behavior:

  1. Open Tool>Night Preferences
  2. Change the 'Default PDF filter' radio button to 'Matching background' or 'Dark'
  3. Press OK
  4. Open any pdf within Zotero
  5. The pdf filter is not correct by default

image

Expected behavior
Setting the default pdf filter should change what the pdf filter is when opening a new file

Windows 10 Build 19044.2251
Zotero Version 6.0.18
Zotero Night version 0.4.19
@JareBear124 JareBear124 added the bug Something isn't working label Nov 23, 2022
@tefkah
Copy link
Owner

tefkah commented Nov 28, 2022

you're right, this doesn't really work correctly, i'll try and fix it

@happyTonakai
Copy link

happyTonakai commented Dec 4, 2022 •
edited
Loading

Same on Win11 with Zotero 6.0.18 and Zotero Night 0.4.20.
But I found that on my another Win10 PC with the exactly same vertion of Zotero and Zotero Night, it works as expected. Then I checked the Night Preferences and the default filter is set to None. After turning it to Dark, it no longer works correctly even I turn it back to None.

@Alpha-Rome0
Copy link

Also experiencing the same as OP

@EnSee
Copy link

EnSee commented Dec 23, 2022

Also have the same issue. Checking it's not a settings prob?
Thanks for your work

@zhbery
Copy link

zhbery commented Dec 29, 2022

Same issue. Hope it can be addressed soon. Thanks for the great plugin.

@Bobo-alcazar
Copy link

Same on Win10 with Zotero 6.0.19 and Zotero Night 0.4.20.

@luyur
Copy link

luyur commented Feb 6, 2023 •
edited
Loading

Me too, but my coumputer is mac 10.15.7.

@Social-Mean
Copy link

Same on Win10 22H2 with Zotero 6.0.20 and Zotero-night 0.4.20.

@happyTonakai
Copy link

I downgraded to night v0.4.8 and this works fine for Zotero 6.0.20.

@zhbery
Copy link

zhbery commented Feb 16, 2023

I downgraded to night v0.4.8 and this works fine for Zotero 6.0.20.

That works. Thank you guy!

@Social-Mean
Copy link

I downgraded to night v0.4.8 and this works fine for Zotero 6.0.20.

Yeah, it works well and thanks. But can someone fix the bug in the newest version of zotero-night?

@biggusbeetus biggusbeetus mentioned this issue Mar 24, 2023
Closed
@NIL-zhuang
Copy link

Same problem exists for zotero 6.0.23, macOS 13.3.1, night v0.4.20

@mKobrow mKobrow mentioned this issue Apr 13, 2023
Open
@happyTonakai happyTonakai mentioned this issue Aug 22, 2023
Closed
@tefkah
Copy link
Owner

tefkah commented Sep 5, 2023

This should work in the latest version, let me know if not.

@tefkah tefkah closed this as completed Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tefkah tefkah

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix default pdf-filter behavior mKobrow/zotero-night
10 participants
@Alpha-Rome0 @happyTonakai @tefkah @zhbery @NIL-zhuang @EnSee @luyur @Bobo-alcazar @JareBear124 @Social-Mean