Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New GraphQL ppx instructions incomplete #121

Closed
gugahoa opened this issue Nov 6, 2019 · 1 comment · Fixed by #125
Closed

New GraphQL ppx instructions incomplete #121

gugahoa opened this issue Nov 6, 2019 · 1 comment · Fixed by #125

Comments

@gugahoa
Copy link
Contributor

gugahoa commented Nov 6, 2019

The way to generate a graphql_schema.json is different on graphql_ppx_re so the instructions on the README right now will lead to an error when setting up a new project

We should copy the instructions from graphql_ppx_re and have another section with instructions if the user decides to use graphql_ppx only
@parkerziegler
Copy link
Contributor

@gugahoa Totally agree, I have some local docs changes that will fix this. I'll push them up tomorrow when I get a moment.

@parkerziegler parkerziegler mentioned this issue Nov 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve API docs, including instructions on graphql_ppx_re. teamwalnut/rescript-urql
2 participants
@gugahoa @parkerziegler