Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could you describe some more basic informations in README.md? #12

Open
Shiwoo-Park opened this issue Sep 5, 2022 · 2 comments
Open

Comments

@Shiwoo-Park
Copy link

Please add version info of these

  • python
  • fastapi
@teamhide
Copy link
Owner

teamhide commented Sep 5, 2022

You can check it through pyproject.toml. However, you can bump up version on your needs.

@thomaslc66
Copy link

thomaslc66 commented Jan 3, 2023

It's a good comment, I'm struggling to start this project.

I can't understand if we can use it with psql, there's not a lot of information regarding poetry and the install process of dependencies.

It's missing some example or context,

Can't understand why there is a config.py with all the URLs in clear but not a .env file to store env variables, that might be more secure, especially when there is nothing that avoids committing this file in the .gitignore.

What is the point to have a READER database, is it something that is used for tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants