Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add -DUSE_ATOMIC_FALLBACKS to OpenSSL build script (iOS) #3175

Closed
wants to merge 1 commit into from
Closed

Add -DUSE_ATOMIC_FALLBACKS to OpenSSL build script (iOS) #3175

wants to merge 1 commit into from

Conversation

vincentneo
Copy link
Contributor

To fix #3171, where when compiling TDLib for Apple Watch, if OpenSSL 3.4.0 is used, will cause a crash when ran on device.

@levlam
Copy link
Contributor

levlam commented Dec 8, 2024 •
edited
Loading

This is a bug in OpenSSL 3.4.0 and I suggested to add -DUSE_ATOMIC_FALLBACKS just to comfirm the cause of the bug.
Using the define can significantly affect OpenSSL performance, hence it must not be used in production, and the issue is fixed in the OpenSSL repository instead.

@vincentneo vincentneo closed this Dec 8, 2024
@vincentneo
Copy link
Contributor Author

Alright!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TDLib crashes when compiled with OpenSSL 3.4.0
2 participants
@vincentneo @levlam