Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 #8

Open
RyanBalfanz opened this issue Mar 24, 2017 · 4 comments
Open

Python 3 #8

RyanBalfanz opened this issue Mar 24, 2017 · 4 comments

Comments

@RyanBalfanz
Copy link
Collaborator

I'm willing to do this work too.

@tdeck
Copy link
Owner

tdeck commented Mar 26, 2017

Good idea. I'm working to de-crapify rtmbot.py so there's potentially less code to convert. It's doing a lot of things that we don't actually need and I never cleaned it up because nobody ever worked on this code before :).

@tdeck
Copy link
Owner

tdeck commented Mar 30, 2017

It looks like the only change is s/iteritems/items/, according to 2to3. I'm testing it out!

@RyanBalfanz
Copy link
Collaborator Author

Sweet, don't forget to add Python 3.6, etc. to .travis.yml. :)

@tdeck
Copy link
Owner

tdeck commented Mar 30, 2017

I played with this a bit in the python3 branch (pushed). Noticed a couple of issues:

  • After starting in Python 3, teambot couldn't read the DB file I'd previously created under Python 2.7. So that does make migration potentially tougher for some people. If anyone's actually using this and migrating an existing database to Python 3, I'm sure we can write a script or some kind of export functionality to make it easier.
  • The slackclient lib we depend on doesn't support Python 3. I get an error when running it. It's a bit puzzling since it's 2017 and this is an official Slack library, but they do have a bug open for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants