New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass encoding to readFile #4

Open

humphd opened this issue Sep 21, 2021 · 0 comments

humphd commented Sep 21, 2021

In https://github.com/tcvan0707/txt2html/blob/main/src/txt2html.js#L36 you cast to a string. A better way to do this is to request that node encode the resulting buffer as a utf-8 string:

const text = await fs.readFile(filePath, 'utf-8');

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment